Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply suggestions in mini-lsm #20

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented Jan 30, 2023

Signed-off-by: Alex Chi iskyzh@gmail.com

Signed-off-by: Alex Chi <iskyzh@gmail.com>
@skyzh
Copy link
Contributor Author

skyzh commented Jan 30, 2023

cc @Folyd would you please table a look and merge to your PR? (I don't have edit access to your branch 🤪)

Copy link
Contributor

@Folyd Folyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@Folyd Folyd merged commit 095bd80 into RustMagazine:skyzh-minilsm Jan 31, 2023
Folyd added a commit that referenced this pull request Feb 1, 2023
… using Rust (#9)

* New article: MiniLSM: A Tutorial of Building Storage Engine in a Week using Rust

* Add tutorial topic

* apply suggestions (#20)

Signed-off-by: Alex Chi <iskyzh@gmail.com>

---------

Signed-off-by: Alex Chi <iskyzh@gmail.com>
Co-authored-by: Alex Chi <iskyzh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants