Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add full-lexer feature #36

Merged
merged 2 commits into from
May 15, 2023
Merged

Add full-lexer feature #36

merged 2 commits into from
May 15, 2023

Conversation

youknowone
Copy link
Member

Disabling full-lexer feature makes parsing Lib/**/*.py 4% faster.

Ruff will need to enable this feature to use Tok::Comment

cc @MichaReiser @charliermarsh

DimitrisJim
DimitrisJim reviewed May 15, 2023
View reviewed changes
parser/src/lexer.rs Outdated Show resolved Hide resolved
@youknowone youknowone mentioned this pull request May 15, 2023
Open
DimitrisJim
DimitrisJim approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was mentioned in the past at some point. I think its a good idea to have a feature like this.

@youknowone @DimitrisJim
Update parser/src/lexer.rs
825d8f5 
Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com>
@youknowone youknowone merged commit 27e3873 into RustPython:main May 15, 2023
@youknowone youknowone deleted the full-lexer branch May 15, 2023 17:21
@youknowone youknowone mentioned this pull request May 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DimitrisJim DimitrisJim DimitrisJim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youknowone @DimitrisJim