compatiblity updates with HARPS and HARPS-N spectra #12
Conversation
Codecov Report
@@ Coverage Diff @@
## main #12 +/- ##
==========================================
- Coverage 31.00% 30.63% -0.38%
==========================================
Files 19 19
Lines 987 999 +12
==========================================
Hits 306 306
- Misses 681 693 +12
Continue to review full report at Codecov.
|
| @@ -55,20 +55,23 @@ function apply_doppler_boost!(spectra::AS, dict::AbstractDict ) where { AS<:Abst | |||
| doppler_factor *= calc_doppler_factor(dict[:drift_rv]) | |||
| end | |||
| =# | |||
| if !haskey(dict,:ssb_rv) && !haskey(dict,:ssbz) && !have_issued_ssb_warning | |||
| if !haskey(dict,:ssb_rv) && !haskey(dict,:ssbz) && !haskey(dict,:ssb_rv_kmps) && !have_issued_ssb_warning | |||
There was a problem hiding this comment.
If we're going to allow either of these, then let's add a check that both aren't set.
There was a problem hiding this comment.
I updated this so a warning is printed if both are set, so the user knows which is used by default.
| @assert 1 <= min_pixel_in_order(inst) <= max_pixel_in_order(inst) <= size(λ,1) | ||
| @assert 1 <= min_order(inst) <= max_order(inst) <= size(λ,2) | ||
| @assert 1 <= size(λ,1) <= max_pixel_in_order(inst) | ||
| @assert 1 <= size(λ,2) <= max_order(inst) | ||
| Spectra2DBasic{eltype(λ),eltype(flux),eltype(var),typeof(λ),typeof(flux),typeof(var),typeof(inst)}(λ,flux,var,inst,metadata) |
There was a problem hiding this comment.
I agree max_... should be less than size... But why not leave the check for min... being bigger than 1 and less than max?
There was a problem hiding this comment.
can add separate line that min_order is between 1 and max_order
support for km/s RV shifts and a binary RV shift