Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always support fo4 dds archive, even on linux #11

Merged
merged 2 commits into from
Jun 18, 2023
Merged

always support fo4 dds archive, even on linux #11

merged 2 commits into from
Jun 18, 2023

Conversation

Guekka
Copy link
Contributor

@Guekka Guekka commented Jun 18, 2023

With the recent progress on directxtex, it is now possible to use it on Linux

@codecov
Copy link

codecov bot commented Jun 18, 2023

Codecov Report

Merging #11 (092281f) into master (d8e5143) will increase coverage by 0.25%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage   89.54%   89.79%   +0.25%     
==========================================
  Files          19       19              
  Lines        2649     2656       +7     
==========================================
+ Hits         2372     2385      +13     
+ Misses        277      271       -6     
Impacted Files Coverage Δ
src/bsa/fo4.cpp 91.90% <100.00%> (+0.85%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80f8e24...092281f. Read the comment docs.

vcpkg.json Show resolved Hide resolved
src/CMakeLists.txt Outdated Show resolved Hide resolved
cmake/config.cmake.in Outdated Show resolved Hide resolved
@Guekka
Copy link
Contributor Author

Guekka commented Jun 18, 2023

Thanks for your quick review, that's impressive

Please squash the commits when merging

@Ryan-rsm-McKenzie Ryan-rsm-McKenzie merged commit a7e00b1 into Ryan-rsm-McKenzie:master Jun 18, 2023
@Guekka Guekka deleted the linux-fo4dds branch June 18, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants