Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes for marker appearing at geocoder search, replaced with popup #27

Merged
merged 2 commits into from
Oct 16, 2024
Merged

fixes for marker appearing at geocoder search, replaced with popup #27

merged 2 commits into from
Oct 16, 2024

Conversation

RyanBirtch-aot
Copy link
Owner

Description

Types of changes

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have run the npm script lint on the frontend and backend
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have approval from the product owner for the contribution in this pull request

Further comments

abhilash-aot
abhilash-aot reviewed Oct 16, 2024
View reviewed changes
components/src/components/Map/services/MapService.ts Outdated
});
map.addControl(geocoderControl);
map.on('geosearch/showlocation', (e) => {
console.log((e as any).location);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove console

@abhilash-aot
Update MapService.ts
d7605f3 
console removed
abhilash-aot
abhilash-aot approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@abhilash-aot abhilash-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for Geocoder changes to hide Marker and show popup only

@abhilash-aot abhilash-aot merged commit e11aed0 into feat-map Oct 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhilash-aot abhilash-aot abhilash-aot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RyanBirtch-aot @abhilash-aot