Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FORMS-1580 - Required Field Flag for Maps #33

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Conversation

RyanBirtch-aot
Copy link
Owner

@RyanBirtch-aot RyanBirtch-aot commented Dec 16, 2024

Description

Added the Required flag into the form designer UI. Overloaded the existing formio implementation of isEmpty, which is what is checked when validating the required value. Also added a feature to prevent the user from deleting the default features added to the map by the form designer, as such deletions would interfere with the required flag as well as any limitations placed on the number of features added to the map

Type of Change

feat (a new feature)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have run the npm script lint on the frontend and backend
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have approval from the product owner for the contribution in this pull request

Further comments

@RyanBirtch-aot RyanBirtch-aot merged commit 438a3ca into feat-map Dec 17, 2024
6 checks passed
@RyanBirtch-aot RyanBirtch-aot deleted the map-required-bug branch December 17, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants