Add validators and refactor soft parameter (Splited from 197) #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pitbulk
commented
May 12, 2015
pitbulk
commented
- Avoid the use of the soft parameter in each validator.
- Refact validations.
- Add test.
…ft parameter from validators. Created the ivar soft that is initialized with the settings.soft. Removed the validate! method
|
Re-factorized the soft parameters of validators on the Logoutresponse class. @Lordnibbler, @luisvm Please validate this so I can do the same on Response and LogooutRequest classes. |
pitbulk
changed the title
|
👍 |
|
@phlipper this change is what you suggested at #197 (comment) ?? |
|
@pitbulk this looks like a nice improvement, thanks! |
| def valid_response(opts = {}) | ||
| opts = default_response_opts.merge!(opts) | ||
| def valid_logout_response_document(opts = {}) | ||
| opts = default_logout_response_opts.merge!(opts) |
There was a problem hiding this comment.
do we really want to alter default_logout_response_opts? it's being modified when using merge!
|
👍 lgtm! |
pitbulk
added a commit
that referenced
this pull request
May 26, 2015
Add validators and refactor soft parameter (Splited from 197)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.