Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow metadata to be retrieved from source containing data for multiple entities #373

Closed
wants to merge 3 commits into from

Conversation

reggieb
Copy link

@reggieb reggieb commented Jan 30, 2017

Sometimes the source of SAML Metadata publishes a particular set of configuration data within a larger set of data for many SAML entities. The issue has been raised previously in #346

Where this is the case, <md:EntityDescriptor> may not be defined at the root of the Metadata XML, but is within <md:EntitiesDescriptor>.

This modification allows for the three use cases I have seen:

  1. <md:EntityDescriptor> is at the Metadata root and the data refers to only one SAML entity (currently handled)
  2. <md:EntityDescriptor> is within <md:EntitiesDescriptor> and the data refers to only one SAML entity
  3. <md:EntityDescriptor> is within <md:EntitiesDescriptor> and the data refers to many SAML entities

For case three, the particular entity descriptor data to be retrieved can be specified in the parse call (as detailed in the updated README)

@reggieb
Copy link
Author

reggieb commented Jan 31, 2017

One of the Travis builds has stalled:

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

Is that a JRuby Nokogiri issue?

@pitbulk
Copy link
Collaborator

pitbulk commented Apr 21, 2017

Hi @reggieb

sorry for the delay.

I included your PR in a another PR-389:

@pitbulk pitbulk closed this Apr 21, 2017
@pitbulk pitbulk mentioned this pull request Apr 21, 2017
4 tasks
@reggieb
Copy link
Author

reggieb commented Apr 21, 2017

OK. thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants