Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: issues affecting the code quality #567

Merged
merged 8 commits into from
Jan 2, 2023
Merged

Fix: issues affecting the code quality #567

merged 8 commits into from
Jan 2, 2023

Conversation

withshubh
Copy link
Contributor

Description

This PR fixes a few issues that were affecting the code quality.

Summary of changes

  • Prefer rescuing StandardError over Exception
  • Prefix any unused method arguments with an underscore
  • Remove redundant and unnecessary require statement
  • Replaces the old OpenSSL algorithmic constants with the newer strings initializers
  • Remove redundant string coercion
  • Remove useless access modifiers

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 97.999% when pulling 925a10a on withshubh:master into b3f2191 on onelogin:master.

@coveralls
Copy link

coveralls commented Feb 18, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-1.2%) to 96.791% when pulling b71ca2f on withshubh:master into b3f2191 on onelogin:master.

pitbulk
pitbulk reviewed Feb 22, 2021
View reviewed changes
lib/onelogin/ruby-saml/response.rb
@@ -727,7 +727,7 @@ def validate_issuer
# @return [Boolean] True if the SessionNotOnOrAfter of the AuthnStatement is valid, otherwise (when expired) False if soft=True
# @raise [ValidationError] if soft == false and validation fails
#
def validate_session_expiration(soft = true)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we can simply remove the param

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pitbulk removed!:sparkles:

@withshubh
Copy link
Contributor Author

Hi @pitbulk 👋

Please review the PR ✨

@johnnyshields
Copy link
Collaborator

johnnyshields commented Aug 8, 2021 •
edited
Loading

👍 looks good to merge

@johnnyshields
Copy link
Collaborator

@pitbulk let's merge this one?

@pitbulk pitbulk merged commit 82f08a3 into SAML-Toolkits:master Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pitbulk pitbulk pitbulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@withshubh @coveralls @johnnyshields @pitbulk