Fixed memory leak for RFCTYPE_XSTRING #246
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwrfcsdk.cc:618 - byteValue does not free automatically, added finalizer to free byteValue once no longer needed.
|
why is this closed, is it some undesired side-effect found during testing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allocated
byteValuein nwrfcsdk.cc:618 is not freed automatically (a fact that only becomes apparent if you transfer very large XSTRING types) resulting in a memory leak that is significant for applications that deal with large amounts of XSTRING data (my app would, for instance, would crash after a few minutes due to lack of memory - others will likely not experience it on this kind of scale, but the memory leak is nevertheless a concern in my opinion).The fix is very simple and uses the finalizer feature of
node-addon-api. Looking forward to your comments