Set flexibility services correctly, bump UI5 version #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-kobo
changed the title
drktfl
approved these changes
Dec 7, 2023
stewsk
reviewed
Dec 7, 2023
| @@ -16,14 +16,14 @@ | |||
| </style> | |||
| <script | |||
| id="sap-ui-bootstrap" | |||
| src="https://ui5.sap.com/1.119.2/resources/sap-ui-core.js" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a recent change in SAPUI5, flexibility services mustn't be set empty in the index.html, as this breaks the runtime when running with the actual SAPUI5 version.
This PR fixes the runtime issue and now also enables to e.g. save filter personalization variants when running the app locally.
Bumping the UI5 version to 1.120.1 in that course.