Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in fields documentation #176

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Conversation

vtintillier
Copy link
Member

k is actually used instead of l. Not sure if this has changed at some point or if the documentation was never correct.

@KarstenSchnitter
Copy link
Contributor

Thanks for providing this PR. The asciidoc is actually generated from /beats/app-logs/etc/fields.yml. You need to make the changes in that file and regenerate the asciidoc.

Unfortunately the asciidoc generation is a little cumbersome to execute. If it does not work for you, I can do that.

@vtintillier vtintillier changed the title Fix typo in fields.asciidoc Fix typo in fields documentation Mar 5, 2024
@vtintillier
Copy link
Member Author

Done 👍

Copy link
Contributor

@KarstenSchnitter KarstenSchnitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this great contribution.

@KarstenSchnitter KarstenSchnitter merged commit 26565dc into SAP:main Mar 6, 2024
2 checks passed
@vtintillier vtintillier deleted the patch-1 branch March 6, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants