remove httpclient caching from DefaultHttpClientFactory #1413
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HttpClient
caching inDefaultHttpClientFactory
does not add any value to the way how it is used across the other library modules, where the createdhttpClient
is stored as a field variable in the corresponding classes and reused from there.Moreover, as the service configuration is loaded once per app start, extending a cache with a cache key that include a clientid, a certificate thumbprint and implementing also a cache eviction logic would not have any impact on key rotation without app restart and therefore caching the http connections would not bring anything.