Skip to content

Commit

Permalink
chore(ci): bump netlify node version
Browse files Browse the repository at this point in the history
  • Loading branch information
droshev committed Dec 20, 2024
1 parent b29508c commit 7e7e014
Show file tree
Hide file tree
Showing 15 changed files with 1,450 additions and 737 deletions.
21 changes: 15 additions & 6 deletions .github/actions/nodejs/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ inputs:
node-version:
description: Node.js version
required: false
default: 20.x
default: 22.x
frozen-lockfile:
description: Install dependencies from lock file
required: false
Expand All @@ -23,18 +23,27 @@ runs:
shell: bash
run: npm install -g corepack

- name: Enable Corepack for Yarn 4.5.1
- name: Enable Corepack for Yarn 4.5.3
shell: bash
run: |
corepack enable yarn && yarn
corepack enable yarn
- name: Install Yarn 4.5.1 (if not available)
- name: Run Yarn
shell: bash
run: |
if ! yarn --version | grep -q "4.5.1"; then
npm install -g yarn@4.5.1
yarn
- name: Install Yarn 4.5.3 (if not available)
shell: bash
run: |
if ! yarn --version | grep -q "4.5.3"; then
npm install -g yarn@4.5.3
fi
- name: Print Node.js version
shell: bash
run: node --version

- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "dir=$(yarn config get cacheFolder)" >> $GITHUB_OUTPUT
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/create-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ jobs:
strategy:
matrix:
agent: [1, 2, 3, 4, 5]
node-version: [22.x]
steps:
- uses: actions/checkout@v4.2.2
- uses: ./.github/actions/nodejs
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/on-pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ jobs:
strategy:
matrix:
agent: [1, 2, 3, 4, 5, 6, 7, 8]
node-version: [22.x]
steps:
- uses: actions/checkout@v4.2.2
- uses: ./.github/actions/nodejs
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v20.14.0
v22.12.0
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable @angular-eslint/no-host-metadata-property */
import { DOWN_ARROW, LEFT_ARROW, RIGHT_ARROW } from '@angular/cdk/keycodes';
import { NgTemplateOutlet } from '@angular/common';
import {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ const FD_NAVIGATION_OVERFLOW_ITEM_CLASS = 'fd-navigation__container--hidden-over
imports: [PortalModule, NgTemplateOutlet, NavigationListComponent, NavigationMoreButtonComponent],
changeDetection: ChangeDetectionStrategy.OnPush,
encapsulation: ViewEncapsulation.None,
// eslint-disable-next-line @angular-eslint/no-host-metadata-property
host: {
class: 'fd-navigation__container fd-navigation__container--top',
'[style.flex-grow]': '1'
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable @angular-eslint/no-input-rename,@angular-eslint/no-host-metadata-property */
import { FocusKeyManager } from '@angular/cdk/a11y';
import { DOWN_ARROW, UP_ARROW } from '@angular/cdk/keycodes';
import { NgTemplateOutlet } from '@angular/common';
Expand Down
1 change: 0 additions & 1 deletion libs/cdk/utils/functions/element-size.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ const ELEMENT_DIMENSIONS = { width: 100, margin: 2, padding: 5 };

@Component({
template: '',
// eslint-disable-next-line @angular-eslint/no-host-metadata-property
host: {
'[style.display]': '"block"',
'[style.box-sizing]': '"border-box"',
Expand Down
1 change: 0 additions & 1 deletion libs/cdk/utils/functions/intersection-observable.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ class MockIntersectionObserver implements IntersectionObserver {

@Component({
template: '',
// eslint-disable-next-line @angular-eslint/no-host-metadata-property
host: {
'[style.display]': 'elementDisplay',
'[style.box-sizing]': '"border-box"',
Expand Down
1 change: 0 additions & 1 deletion libs/cdk/utils/functions/resize-observable.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ class MockResizeObserver implements ResizeObserver {

@Component({
template: '',
// eslint-disable-next-line @angular-eslint/no-host-metadata-property
host: {
'[style.display]': '"block"',
'[style.box-sizing]': '"border-box"',
Expand Down
2 changes: 1 addition & 1 deletion libs/core/card/header-elements/card-counter.directive.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export class CardCounterDirective implements OnInit, OnChanges, CssClassBuilder
* the status represented by the Object Status.
* can be one of the following: 'negative' | 'critical' | 'positive' | 'informative' | 'neutral'
*/
statusInput = input<ObjectStatus>('neutral', { alias: 'status' });
statusInput = input<ObjectStatus>('neutral');

/** @hidden */
status: ObjectStatus;
Expand Down
1 change: 1 addition & 0 deletions libs/platform/table/table.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -560,6 +560,7 @@ export class TableComponent<T = any>
readonly save = new EventEmitter<SaveRowsEvent<T>>();
/** Event fired when cancel button pressed. */
@Output()
// eslint-disable-next-line @angular-eslint/no-output-native
readonly cancel = new EventEmitter<void>();
/** Event emitted when table body being scrolled. */
@Output()
Expand Down
2 changes: 1 addition & 1 deletion netlify.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
command = "NODE_OPTIONS=--max_old_space_size=8192 npx nx run docs:compile:production-unoptimized --base-href=\"/\""

[build.environment]
NODE_VERSION = "20.15.1"
NODE_VERSION = "22.12.0"
YARN_FLAGS = "--frozen-lockfile"
YARN_VERSION = "4.4.1"
PYTHON_VERSION = "3.8"
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@
"url": "https://github.com/SAP/fundamental-ngx"
},
"engines": {
"yarn": ">= 4.4.1",
"yarn": ">= 4.5.3",
"node": ">= 18"
},
"packageManager": "yarn@4.5.1",
"packageManager": "yarn@4.5.3",
"scripts": {
"preinstall": "npx only-allow yarn",
"build": "echo Building default app && nx compile",
Expand Down Expand Up @@ -155,7 +155,7 @@
"ts-jest": "29.1.0",
"ts-node": "10.9.2",
"tsconfig-paths": "4.1.0",
"typedoc": "0.27.4",
"typedoc": "0.27.5",
"typedoc-plugin-merge-modules": "5.1.0",
"typescript": "5.6.3",
"wait-on": "6.0.1",
Expand Down
Loading

0 comments on commit 7e7e014

Please sign in to comment.