Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): segmented button accessibility improvements #10932

Closed
wants to merge 1 commit into from

Conversation

mikerodonnell89
Copy link
Member

fixes #10805

@mikerodonnell89 mikerodonnell89 added this to the Sprint 125 milestone Nov 9, 2023
@mikerodonnell89 mikerodonnell89 requested a review from a team November 9, 2023 19:39
@mikerodonnell89 mikerodonnell89 self-assigned this Nov 9, 2023
@mikerodonnell89 mikerodonnell89 changed the base branch from main to ng-15-downport November 9, 2023 19:39
Copy link

netlify bot commented Nov 9, 2023

Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit f19f5e3
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/656a034d96a4240008902bfe
😎 Deploy Preview https://deploy-preview-10932--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@droshev droshev added the ng15 Angular 15 support label Nov 10, 2023
@InnaAtanasova InnaAtanasova modified the milestones: Sprint 125, Sprint 126 Nov 10, 2023
Copy link

github-actions bot commented Nov 10, 2023

Visit the preview URL for this PR (updated for commit f19f5e3):

https://fundamental-ngx-gh--pr10932-fix-10805-ng15-ileyb4z0.web.app

(expires Mon, 04 Dec 2023 17:30:00 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff

@InnaAtanasova InnaAtanasova modified the milestones: Sprint 126, Sprint 127 Nov 28, 2023
@droshev droshev force-pushed the fix/10805-ng15 branch 2 times, most recently from 8e633e2 to 9cbfa4e Compare December 1, 2023 15:14
@InnaAtanasova
Copy link
Contributor

<ul 
    role="listbox" 
    aria-multiselectable="false" 
    aria-orientation="horizontal"
    aria-roledescription="Segmented button group" 
    aria-describedby="..." 
    class="..." 
    tabindex="-1">
    <li 
      tabindex="-1" 
      role="option"
      aria-roledescription="Segmented button" 
      aria-posinset="1" 
      aria-setsize="3" 
      aria-selected="false"
      class="..." 
      style="...">
    ...
    </li>
    <li 
      tabindex="0" 
      role="option"
      aria-roledescription="Segmented button" 
      aria-posinset="2" 
      aria-setsize="3" 
      aria-selected="true"
      class="..." 
      style="...">
      ...
    </li>
    <li 
      tabindex="-1" 
      role="option"
      aria-roledescription="Segmented button" 
      aria-posinset="3" 
      aria-setsize="3" 
      aria-selected="false"
      class="..." 
      style="...">
      ...
    </li>
  </ul>

@InnaAtanasova
Copy link
Contributor

@InnaAtanasova InnaAtanasova modified the milestones: Sprint 127, Sprint 128 Dec 12, 2023
@droshev droshev closed this Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ng15 Angular 15 support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[P3.1][Sourcing][Accessibility][Pretest] Segmented button has wrong role as toggle not as per W3 standards
3 participants