-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): shellbar redesign, add branding and additional context area #12694
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Visit the preview URL for this PR (updated for commit 0a31d70): https://fundamental-ngx-gh--pr12694-12520-shellbar-o0tkbkh1.web.app (expires Thu, 26 Dec 2024 15:46:53 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff |
…usage of contex area, add unit tests and examples
…usage of contex area, add unit tests and examples
@dpavlenishvili When I open the menu on a small screen, such as "Corporate Portal" (as shown in the video), the first menu item is selected by default. However, when I open the notification menu (three dots), the first item is not automatically selected. Is this intentional, or should the first item be selected there as well? Screen.Recording.2024-11-25.at.17.00.12.mov |
libs/core/shellbar/shellbar-actions-toolbar/shellbar-actions-toolbar.component.ts
Outdated
Show resolved
Hide resolved
libs/core/shellbar/shellbar-actions/shellbar-actions.component.ts
Outdated
Show resolved
Hide resolved
libs/core/shellbar/shellbar-branding/shellbar-branding.component.html
Outdated
Show resolved
Hide resolved
Cont'd of the Search issue: Screen.Recording.2024-11-29.at.2.26.42.PM.movWhen you hide the search, there's no Search icon that appears. You just completely hide the element. The icon should be visible |
libs/core/shellbar/shellbar-actions-toolbar/shellbar-actions-toolbar.component.ts
Outdated
Show resolved
Hide resolved
libs/core/shellbar/shellbar-actions/shellbar-actions.component.ts
Outdated
Show resolved
Hide resolved
libs/core/shellbar/shellbar-actions/shellbar-actions.component.ts
Outdated
Show resolved
Hide resolved
libs/core/shellbar/shellbar-context-area/shellbar-context-area.component.ts
Outdated
Show resolved
Hide resolved
libs/core/shellbar/shellbar-context-area/shellbar-context-area.component.ts
Outdated
Show resolved
Hide resolved
@dpavlenishvili do we have breaking changes? If so, they need to be documented as well. |
@dpavlenishvili check the current status, investigate whether you can do the overflow menu and write in the PR the status. |
@dpavlenishvili check the current status, investigate whether you can do the overflow menu and write in the PR the status. |
already done: what need to be done: |
Related Issue(s)
closes #12520
Description
Implemented Shellbar ContextArea and integrated Shellbar Branding.
fd-shellbar-branding
fd-shellbar-context-area
for additional elements like separator and spacerfdShellbarHidePriority
directive for custom overflow management with unique priority valuesfdShellbarHidePriority
is omittedScreenshots
Before:
After: