Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to eslint 9 and the flat configuration #12861

Closed
wants to merge 17 commits into from

chore: delete all eslintrc files

831184e
Select commit
Loading
Failed to load commit list.
Closed

chore: update to eslint 9 and the flat configuration #12861

chore: delete all eslintrc files
831184e
Select commit
Loading
Failed to load commit list.
Mergeable / Mergeable failed Dec 23, 2024 in 0s

1/3 Fail(s): APPROVALS

Status: FAIL

    Here are some stats of the run:
    3 validations were ran.
    2 PASSED
    1 FAILED

Details

✔️ Validator: TITLE

  • ✔️ title must exclude '^[WIP]'
    Input : chore: update to eslint 9 and the flat configuration
    Settings : {"must_exclude":{"regex":"^\\[WIP\\]","message":"This is work in progress. Do not merge yet."}}
  • ✔️ title must include '^(feat|docs|chore|fix|test)((\w+))?(:|().+$'
    Input : chore: update to eslint 9 and the flat configuration
    Settings : {"must_include":{"regex":"^(feat|docs|chore|fix|test)(\\(\\w+\\))?(:|\\().+$","message":"Semantic release conventions must be followed."}}

✔️ Validator: DESCRIPTION

  • ✔️ description must exclude '[ ]'
    Input : ## Description

currently the repo is using the old .eslintrc and the unsupport eslint 8 versions
this PR migrate to the new flat configuration and eslint 9

I also updated nx since the old version was buggy, you may want to do the upgrade in a separate branch first which is understandable

note that I didn't add all the old plugins, this can be done in a future PR, or if mandatory I can work on it in the future
Settings : {"must_exclude":{"regex":"\\[ \\]","message":"There are incomplete TODO task(s) unchecked."}}

❌ Validator: APPROVALS

  • (approvals: InnaAtanasova required OR approvals: droshev required OR approvals: dpavlenishvili required OR approvals: mikerodonnell89 required OR approvals count is less than "2")
    Input :
    Settings : {"or":[{"required":{"reviewers":["InnaAtanasova"]}},{"required":{"reviewers":["droshev"]}},{"required":{"reviewers":["dpavlenishvili"]}},{"required":{"reviewers":["mikerodonnell89"]}},{"min":{"count":2}}]}