Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): implement upload-collection in fundamental-ngx #6392

Merged
merged 23 commits into from
Sep 10, 2021
Merged

feat(core): implement upload-collection in fundamental-ngx #6392

merged 23 commits into from
Sep 10, 2021

Conversation

mikerodonnell89
Copy link
Member

@mikerodonnell89 mikerodonnell89 commented Aug 26, 2021 •
edited
Loading

Please provide a link to the associated issue.

Closes #6054

Please provide a brief summary of this pull request.

Implements the Upload Collection in fundamental-ngx/core

Please check whether the PR fulfills the following requirements

Documentation checklist:

@mikerodonnell89 mikerodonnell89 added enhancement New feature or request core Core library specific issues labels Aug 26, 2021
@mikerodonnell89 mikerodonnell89 added this to the Sprint 69 - Pireas milestone Aug 26, 2021
@mikerodonnell89 mikerodonnell89 requested a review from a team August 26, 2021 15:11
@mikerodonnell89 mikerodonnell89 self-assigned this Aug 26, 2021
@netlify
Copy link

netlify bot commented Aug 26, 2021 •
edited
Loading

✔️ Deploy Preview for fundamental-ngx ready!

🔨 Explore the source changes: 95964ad

🔍 Inspect the deploy log: https://app.netlify.com/sites/fundamental-ngx/deploys/613b6e02bf9e1a0007bfa61d

😎 Browse the preview: https://deploy-preview-6392--fundamental-ngx.netlify.app

@github-actions
Copy link

This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days

@github-actions github-actions bot added the stale label Aug 29, 2021
InnaAtanasova
InnaAtanasova reviewed Aug 30, 2021
View reviewed changes
Copy link
Contributor

@InnaAtanasova InnaAtanasova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!!!
I don't see the multiple selection example and an example with download and "Upload new version". Is it left for next stage? https://sapui5.hana.ondemand.com/#/entity/sap.m.UploadCollection/sample/sap.m.sample.UploadCollectionVersioning

libs/core/src/lib/upload-collection/upload-collection-form-item.component.ts Outdated Show resolved Hide resolved
libs/core/src/lib/upload-collection/upload-collection-item.directive.ts Outdated Show resolved Hide resolved
libs/core/src/lib/upload-collection/upload-collection.component.scss Show resolved Hide resolved
libs/core/src/lib/upload-collection/upload-collection.component.scss Show resolved Hide resolved
libs/core/src/lib/upload-collection/upload-collection-simple.directives.ts Outdated Show resolved Hide resolved
Betrozov
Betrozov suggested changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@Betrozov Betrozov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove package-lock.json

libs/core/src/lib/upload-collection/upload-collection-button-group.component.html Outdated Show resolved Hide resolved
libs/core/src/lib/upload-collection/upload-collection-button-group.component.html Outdated Show resolved Hide resolved
libs/core/src/lib/upload-collection/upload-collection-form-item.component.html Outdated Show resolved Hide resolved
libs/core/src/lib/upload-collection/upload-collection-form-item.component.ts Outdated Show resolved Hide resolved
libs/core/src/lib/upload-collection/upload-collection-form-item.component.ts Outdated Show resolved Hide resolved
libs/core/src/lib/upload-collection/upload-collection-form-item.component.ts Outdated Show resolved Hide resolved
libs/core/src/lib/upload-collection/upload-collection-form-item.component.ts Outdated Show resolved Hide resolved
libs/core/src/lib/upload-collection/upload-collection-form-item.component.ts Outdated Show resolved Hide resolved
@mikerodonnell89
Copy link
Member Author

Great job!!!
I don't see the multiple selection example and an example with download and "Upload new version". Is it left for next stage? https://sapui5.hana.ondemand.com/#/entity/sap.m.UploadCollection/sample/sap.m.sample.UploadCollectionVersioning

I did not implement this because it is not in the specs and I think it is probably the developer's responsibility to add the toolbar and the upload collection should not require any additional changes to make this happen. However I can work on adding an example to handle this (or I can add it to all examples)

platon-rov
platon-rov previously requested changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@platon-rov platon-rov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

libs/core/src/lib/upload-collection/upload-collection-button-group.component.html Outdated Show resolved Hide resolved
libs/core/src/lib/upload-collection/upload-collection-button-group.component.ts Outdated Show resolved Hide resolved
@mikerodonnell89
feat(core): some additional PR comments and add a "complex" example u…
1517022 
…tilizing some other components from the library
@github-actions
Copy link

github-actions bot commented Sep 6, 2021

This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days

@github-actions github-actions bot added the stale label Sep 6, 2021
Betrozov
Betrozov suggested changes Sep 6, 2021
View reviewed changes
Copy link
Contributor

@Betrozov Betrozov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove package-lock.json

@platon-rov
Copy link
Contributor

Please take a look into the failing Travis.

@platon-rov
Copy link
Contributor

Also, I found that several components were placed in one folder. Maybe let's create a subfolder for each component (except root one)

image

@mikerodonnell89 mikerodonnell89 merged commit bef24d0 into main Sep 10, 2021
@mikerodonnell89 mikerodonnell89 deleted the feat/upload-collection branch September 10, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@InnaAtanasova InnaAtanasova InnaAtanasova approved these changes

@Betrozov Betrozov Betrozov approved these changes

@droshev droshev Awaiting requested review from droshev droshev is a code owner

@fkolar fkolar Awaiting requested review from fkolar

@valorkin valorkin Awaiting requested review from valorkin

@platon-rov platon-rov Awaiting requested review from platon-rov

Assignees

@mikerodonnell89 mikerodonnell89

Labels
core Core library specific issues enhancement New feature or request
Projects
None yet
Milestone
Sprint 70 - Makawao
Development

Successfully merging this pull request may close these issues.

Upload collection - implementation in ngx
4 participants
@mikerodonnell89 @platon-rov @Betrozov @InnaAtanasova