Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform): update items on new event #8650

Merged
merged 2 commits into from
Sep 15, 2022
Merged

fix(platform): update items on new event #8650

merged 2 commits into from
Sep 15, 2022

Conversation

N1XUS
Copy link
Contributor

@N1XUS N1XUS commented Sep 6, 2022

Related Issue(s)

closes #8629

Description

  • Updated logic of setting rendered items to reflect new items coming from dataSource;
  • Refactored component names and few input properties;
  • Added missing imports/exports to the list module

Please check whether the PR fulfills the following requirements

During Implementation
  1. Visual Testing:
  • visual misalignments/updates
  • check Light/Dark/HCB/HCW themes
  • RTL/LTR - proper rendering and labeling
  • responsiveness(resize)
  • Content Density (Cozy/Compact/(Condensed))
  • States - hover/disabled/focused/active/on click/selected/selected hover/press state
  • Interaction/Animation - open/close, expand/collapse, add/remove, check/uncheck
  • Mouse vs. Keyboard support
  • Text Truncation
  1. API and functional correctness
  • check for console logs (warnings, errors)
  • API boundary values
  • different combinations of components - free style
  • change the API values during testing
  1. Documentation and Example validations
  • missing API documentation or it is not understandable
  • poor examples
  • Stackblitz works for all examples
  1. Accessibility testing
  2. Browser Testing - Edge, Safari, Chrome, Firefox
PR Quality

@N1XUS N1XUS added bug Something isn't working platform platform stackblitz labels Sep 6, 2022
@N1XUS N1XUS added this to the Sprint 96 - Panama City milestone Sep 6, 2022
@N1XUS N1XUS requested a review from a team September 6, 2022 06:10
@N1XUS N1XUS self-assigned this Sep 6, 2022
@netlify
Copy link

netlify bot commented Sep 6, 2022

Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit 65aece0
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/6322e1d87dcf18000a191992
😎 Deploy Preview https://deploy-preview-8650--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Sep 6, 2022

Visit the preview URL for this PR (updated for commit 65aece0):

https://fundamental-ngx-gh--pr8650-fix-8629-update-item-tn5a9nfq.web.app

(expires Sun, 18 Sep 2022 08:36:22 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Copy link
Member

@mikerodonnell89 mikerodonnell89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple comments, see above

libs/platform/src/lib/list/list.component.ts Show resolved Hide resolved
libs/platform/src/lib/list/list.component.ts Show resolved Hide resolved
@N1XUS N1XUS force-pushed the fix/8629-update-items branch from 5e2648c to 65aece0 Compare September 15, 2022 08:27
@N1XUS N1XUS merged commit cbf1e2c into main Sep 15, 2022
@N1XUS N1XUS deleted the fix/8629-update-items branch September 15, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working platform platform stackblitz
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(platform): list items are not updating
3 participants