Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core,platform): update angular 15 and nx to v15 #9056

Merged
merged 1 commit into from
Dec 11, 2022
Merged

feat(core,platform): update angular 15 and nx to v15 #9056

merged 1 commit into from
Dec 11, 2022

Conversation

N1XUS
Copy link
Contributor

@N1XUS N1XUS commented Dec 8, 2022

BREAKING CHANGE:

  • Updated @angular library to v15;
  • Updated nx library to v15;
  • Updated other third-party libraries to latest version;
  • Applied necessary migrations;
  • Adjusted unit tests;
  • For projects without unit tests angular failed karma execution with error that no tests were found, so filler test (dummy) was added to such projects;
  • Build target now ES2022
  • RouterLinkWithHref is now deprecated and removed from @fundamental-ngx/core/link.
  • Value help dialog data provider generic type should be extended from object.

Before:

class ExampleVhdDataProvider<T> extends VhdDataProvider<T> {
    fetch(params: Map<string, string>): Observable<T[]> {
        return super.fetch(params).pipe(delay(300));
    }
}

Now:

class ExampleVhdDataProvider<T extends object> extends VhdDataProvider<T> {
    fetch(params: Map<string, string>): Observable<T[]> {
        return super.fetch(params).pipe(delay(300));
    }
}

@N1XUS N1XUS self-assigned this Dec 8, 2022
@N1XUS N1XUS added the dependencies Pull requests that update a dependency file label Dec 8, 2022
@N1XUS N1XUS added this to the Sprint 102 - Palermo milestone Dec 8, 2022
@netlify
Copy link

netlify bot commented Dec 8, 2022

Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit 96bc1c1
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/639494b6a90ede0008f43d67
😎 Deploy Preview https://deploy-preview-9056--fundamental-ngx.netlify.app/docs/fn/input/examples/input-form-group-example.component
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@N1XUS N1XUS force-pushed the chore/v15 branch 3 times, most recently from 6f6a5fc to 54f364f Compare December 8, 2022 15:11
@github-actions
Copy link

github-actions bot commented Dec 9, 2022

Visit the preview URL for this PR (updated for commit 96bc1c1):

https://fundamental-ngx-gh--pr9056-chore-v15-10lpltvu.web.app

(expires Tue, 13 Dec 2022 14:23:04 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff

@N1XUS N1XUS force-pushed the chore/v15 branch 2 times, most recently from 501f4dc to 90d2859 Compare December 9, 2022 11:04
@droshev droshev added the 0.38 label Dec 9, 2022
@N1XUS N1XUS force-pushed the chore/v15 branch 2 times, most recently from e56e513 to db0ba54 Compare December 9, 2022 12:55
@droshev droshev changed the title [WIP] chore: update angular and nx to v15 feat(core,platform): update angular 15 and nx to v15 Dec 9, 2022
Copy link
Contributor

@platon-rov platon-rov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any major changes, approving.

Please fix pipeline.

migrations.json Show resolved Hide resolved
@N1XUS N1XUS merged commit 47178bf into main Dec 11, 2022
@N1XUS N1XUS deleted the chore/v15 branch December 11, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.38 dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants