Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Website Font Style bleeding inside the components #70

Closed
4 tasks done
joseegm opened this issue Feb 12, 2018 · 2 comments
Closed
4 tasks done

Website Font Style bleeding inside the components #70

joseegm opened this issue Feb 12, 2018 · 2 comments
Assignees
@saad-mo
Labels
Bug Design Website
Milestone
v1.0.0-beta-3

Comments

@joseegm
Copy link
Contributor

joseegm commented Feb 12, 2018 •
edited by saad-mo
Loading

Problem

The Styles of the Website are cascading and bleeding inside the components.

For example the cards
screen shot 2018-02-12 at 14 24 15

This only happen on the website, the kitchen sink app have the correct font
screen shot 2018-02-12 at 14 24 39

Tasks

  • Check all components on the website where this problem might be happening - Leo, Jinjia
  • Change the affected components

Results

  • List of all affected components
  • Changes to the components in the library code
@joseegm joseegm added this to the Dev 002 milestone Feb 12, 2018
@joseegm joseegm modified the milestones: Dev 002, Design 001 Feb 12, 2018
@joseegm joseegm added the Visual label Feb 12, 2018
@saad-mo saad-mo modified the milestones: Design 001, v1.0-beta-2 Feb 12, 2018
@saad-mo saad-mo added the Design label Feb 12, 2018
@jinjiahuangsap
Copy link

Would you mind sharing the tool you are using for checking the style? It looks super cool in the screenshot:) @joseegm

@joseegm
Copy link
Contributor Author

joseegm commented Feb 13, 2018

@jinjiahuangsap Sure: http://www.chengyinliu.com/whatfont.html

saad-mo pushed a commit that referenced this issue Feb 13, 2018
#70 fix site fonts beleeding into components.
4b531ef 
- added default font to each component by updating fd-reset
- change reset to fd-rest.
@saad-mo saad-mo mentioned this issue Feb 13, 2018
Merged
joseegm added a commit that referenced this issue Feb 15, 2018
@joseegm
Merge pull request #78 from SAP/feature/70
362da34 
#70 fix site fonts beleeding into components.
@joseegm joseegm closed this as completed Feb 15, 2018
@joseegm joseegm mentioned this issue Feb 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saad-mo saad-mo

Labels
Bug Design Website
Projects
None yet
Milestone
v1.0.0-beta-3
Development

No branches or pull requests
3 participants
@saad-mo @joseegm @jinjiahuangsap