fix: remove space that is messing with button alignment. #1341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test Version for this PR was deployed Built with commit 7f5ece1 |
|
Looks like the snapshots images need to be updated, but I cannot find any docs on this. Also need to update the docs site css. According to https://github.com/SAP/fundamental/wiki/Contribution-Guidelines#5-run-the-documentation, I should just have to |
greg-a-smith
suggested changes
Mar 23, 2019
docs/css/fiori-fundamentals.css
Outdated
| @@ -3549,7 +3549,7 @@ This will render 4 boxes spanning 2 cols each indented 2 cols | |||
| -webkit-box-shadow: 0 0 0 1px var(--fd-color-action-focus); | |||
| box-shadow: 0 0 0 1px var(--fd-color-action-focus); } | |||
| [dir="rtl"] .fd-alert__close, .fd-alert__close[dir="rtl"] { | |||
| left: 4px; | |||
| left: 0; | |||
There was a problem hiding this comment.
I think this PR should be held until #1345 is merged. The files fui-site.css and fiori-fundamentals.css are no longer required to be updated in source control (since they are generated).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1271
orig:
fixed:
