fix: Feature/toggle updates #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
May 28, 2019 11:44
|
Deploy preview for fundamental ready! Built with commit d327505 |
|
@SAP/fiori-fundamentals can someone please review. This is a small updated to bring back the no-duplicate-selectors linting rule. |
LeoT7508
suggested changes
Jul 9, 2019
There was a problem hiding this comment.
- The slider bar online is incorrect on the "on" state.
- Both states circle shape need a shadow.
- The switch handle isn't centered vertically in this "extra small" version.
Details can be found in the design sheet here: https://zpl.io/VDqLL8W
droshev
pushed a commit
that referenced
this pull request
Jul 16, 2020
* Update toggle component to match design specs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings back
no-duplicate-selectorslint rule and minor refactoring totogglescss to address the lint exceptions