Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Asset Upload component #1509

Merged
merged 8 commits into from
Jul 9, 2019
Merged

feat: Asset Upload component #1509

merged 8 commits into from
Jul 9, 2019

Conversation

saad-mo
Copy link
Contributor

@saad-mo saad-mo commented Jul 1, 2019

Closes #1508

adds new asset upload component

Screen Shot 2019-07-01 at 4 44 32 PM

Test

Changelog

New

  • asset upload component

Changed

nothing

Removed

nothing

@saad-mo saad-mo requested review from droshev and LeoT7508 July 1, 2019 21:57
@saad-mo saad-mo changed the title Feature/1508 asset upload feat: Asset Upload component Jul 1, 2019
@saad-mo saad-mo requested review from JYSW380 and SaiShan July 1, 2019 21:58
@netlify
Copy link

netlify bot commented Jul 1, 2019 •
edited
Loading

Deploy preview for fundamental ready!

Built with commit e48f1de

https://deploy-preview-1509--fundamental.netlify.com

@saad-mo
Copy link
Contributor Author

saad-mo commented Jul 1, 2019

@LeoT7508 - https://deploy-preview-1509--fundamental.netlify.com/components/asset-upload.html

LeoT7508
LeoT7508 suggested changes Jul 3, 2019
View reviewed changes
Copy link

@LeoT7508 LeoT7508 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the spacing of elements is off. There should be 12px padding around the information inside. There should be 4px between the icon(16px) and the text below, there isn't any space in between the two lines of text.

@saad-mo
Copy link
Contributor Author

saad-mo commented Jul 5, 2019

It looks like the spacing of elements is off. There should be 12px padding around the information inside. There should be 4px between the icon(16px) and the text below, there isn't any space in between the two lines of text.

  • padding is 12px
  • 4px space added between icon and text
  • added 2px spacing between

LeoT7508
LeoT7508 approved these changes Jul 8, 2019
View reviewed changes
Copy link

@LeoT7508 LeoT7508 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@saad-mo saad-mo merged commit 49dd334 into master Jul 9, 2019
@saad-mo saad-mo deleted the feature/1508-asset-upload branch July 9, 2019 18:50
@saad-mo saad-mo mentioned this pull request Jul 18, 2019
Merged
droshev pushed a commit that referenced this pull request Jul 16, 2020
@droshev
feat: Asset Upload component (#1509)
5d9d660 
* Add asset-upload component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeoT7508 LeoT7508 LeoT7508 approved these changes

@droshev droshev Awaiting requested review from droshev

@JYSW380 JYSW380 Awaiting requested review from JYSW380

@SaiShan SaiShan Awaiting requested review from SaiShan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Sprint 14 - Wun Weg Wun Dar Wun
Development

Successfully merging this pull request may close these issues.

Lib: Asset Upload Button
2 participants
@saad-mo @LeoT7508