docs: add ui kit and learn more to landing page #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental ready! Built with commit befae70 |
stefanoScalzo
force-pushed
the
docs-ui-kit
branch
from
929a3ce
to
3f8ddba
Compare
There was a problem hiding this comment.
The following comments are just a personal opinion as I am not a designer and can't really comment on this :)
- On very big screen the
Downloadbutton looks weird. I think it should be centered. The 3 sections under it look weird- they are too small with a lot of space between them. The Learn more items are too big
- The spacing on the left and right side is not the same. We have more space on the left hand side which makes the items look like they are not centered.
- Overlapping of the "Go to top" arrow and content
- UI kit bundle sections look too close in Tablet view. Maybe show 2 sections per row in this case?
- Hamburger button showing when links are showing too in Tablet view
| &__title { | ||
| @extend %text; | ||
|
|
||
| @include text(); |
There was a problem hiding this comment.
why did you change it to mixin?
There was a problem hiding this comment.
so that I could use it easily in media querys, it wasnt letting me without
stefanoScalzo
force-pushed
the
docs-ui-kit
branch
from
3c19eae
to
848bbd0
Compare
|
Everything looks pretty good. I notice a few things for the large screen:
|
droshev
previously requested changes
Aug 20, 2020
estelaxu3
approved these changes
Aug 20, 2020
stefanoScalzo
force-pushed
the
docs-ui-kit
branch
from
bd15483
to
befae70
Compare
droshev
approved these changes
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1553
Add UI kit and learn more sections to landing page