BUG - guide search is very inconsistent

[hitesh-parmar]

Related Feature

Feature request: issue number

Description

Steps to Reproduce

1] Open Guided Answers extension
2] Enter the search term "fiori"
3] Various search results are listed and more search results are fetched by scrolling

Issue 1

Keep scrolling down and at one point there is just a loading indicator but no search results are fetched. Is this because there are no more results to fetch? If yes, then we should simply show the message "No more results, please extend your search"

Decision - do not show loading indicator and scroll should not be possible anymore.

4] Now clear the search term and enter fiori again

Issue 2

Only one entry is fetched

5] Cancel the search term again

Issue 3

Now suddenly we see 3 entries

6] Now try entering other search terms like business or services`

Issue 4

Still, only one entry is fetched

Issue 5

With the search term SAP Fiori Tools ideally 3 results should be shown, but sometimes only 1 result is shown

Issue 6

When there is no search term, sometimes a long list of results is shown which expands on scrolling and sometimes only a few entries are shown
How is the long list of entries shown when there is no search term? What is the logic behind this?

See the attached video:

2024-08-09_13-01-05.mp4

Expected results

Search needs to behave consistently.

When there is no search term we should default to the same behavior as in the web version. https://ga.support.sap.com/dtp/viewer/

Version/Components/Environment

Add any other context about the problem here
OS:

• Mac OS
• Windows
• Other

Root Cause Analysis

Problem

{describe the problem}

Fix

{describe the fix}

Why was it missed

{Some explanation why this issue might have been missed during normal development/testing cycle}

How can we avoid this

{if we don’t want to see this type of issues anymore what we should do to prevent}

[hitesh-parmar]

@gpeuc What do you think of this proposal? or shall we rather always show no entries when there is no search term?

When there is no search term we should default to the same behavior as in the web version. https://ga.support.sap.com/dtp/viewer/

[gpeuc]

Oh wow, search is really broken. I typed "fiori" in the search box, and then I just delete "i" and retype it again. So I have "fior" and then "fiori". Every time I do that I get a different number of results. Sometimes 1 result, sometimes 5, sometimes so many that I need to scroll down and it lazy-loads more results. It's absolutely broken.

I think this same thing happens when there's nothing in search box. Sometimes it loads a few results, sometimes it loads a long list, and so on. Someone should really look into why is search behaving inconsistently like this.

When there's nothing in search, we should just fetch all (and lazy-load it, of course, so we don't take much resources).

Regarding loading: when there's nothing more to load, there is no need to write anything. Otherwise we could repeat that same text when there's only 3 results or some other small number that fits easily on the first screen. When we scroll to the end, we just scroll to the end (and remove loader, of course), that's it.