Error handling global search centered (#2527)

SAP · Feb 18, 2022 · 8736720 · 8736720
1 parent e6dee1b
commit 8736720
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 7 deletions.
diff --git a/core/src/navigation/GlobalSearch.svelte b/core/src/navigation/GlobalSearch.svelte
@@ -43,6 +43,7 @@
   });
 
   function getCustomRenderer() {
+    if(!search.searchProvider)return;
     isCustomSearchRenderer = GenericHelpers.isFunction(
       search.searchProvider.customSearchResultRenderer
     );
@@ -87,7 +88,7 @@
   }
 
   function onKeyUp({ keyCode }) {
-    if (search) {
+    if (search && search.searchProvider) {
       if (
         GenericHelpers.isFunction(search.searchProvider.onEnter) &&
         keyCode === KEYCODE_ENTER
@@ -214,7 +215,7 @@
       luigiCustomSearchRenderer__slot
     });
 
-    if (GenericHelpers.isFunction(search.searchProvider.toggleSearch)) {
+    if (search && search.searchProvider && GenericHelpers.isFunction(search.searchProvider.toggleSearch)) {
       const fieldVisible =
         isSearchFieldVisible === undefined ? true : !isSearchFieldVisible;
       search.searchProvider.toggleSearch(inputElem, fieldVisible);

diff --git a/core/src/navigation/GlobalSearchCentered.svelte b/core/src/navigation/GlobalSearchCentered.svelte
@@ -44,11 +44,13 @@
     getCustomRenderer();
     GlobalSearchHelper.handleVisibilityGlobalSearch();
     const globalSearchCtn = document.querySelector('.lui-global-search');
-    const resizeObserver = new ResizeObserver(entries => {
-      GlobalSearchHelper.handleVisibilityGlobalSearch();
-    });
-
-    resizeObserver.observe(globalSearchCtn);
+    if (globalSearchCtn) {
+      const resizeObserver = new ResizeObserver(entries => {
+        GlobalSearchHelper.handleVisibilityGlobalSearch();
+      });
+  
+      resizeObserver.observe(globalSearchCtn);
+    }
   });
 
   beforeUpdate(() => {

diff --git a/core/src/utilities/helpers/global-search-helpers.js b/core/src/utilities/helpers/global-search-helpers.js
@@ -3,6 +3,7 @@ class GlobalSearchHelperClass {
   constructor() {}
 
   handleVisibilityGlobalSearch() {
+    if (!document.querySelector('.lui-global-search')) return;
     const globalSearchCtn = document.querySelector('.lui-global-search');
     const condition = globalSearchCtn.offsetWidth <= 384;
     globalSearchCtn.classList.toggle('lui-global-search-toggle', condition);