Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make logo and title in Luigi configurable #139

Closed
korisantosh opened this issue Oct 16, 2018 · 2 comments
Closed

Make logo and title in Luigi configurable #139

korisantosh opened this issue Oct 16, 2018 · 2 comments
Assignees
@maxmarkus
Labels
enhancement New feature or request

Comments

@korisantosh
Copy link

Is it possible to make logo and title editable in Luigi configatation

Reasons
It will help to build brand trust
@hardl hardl added enhancement New feature or request area/luigi labels Oct 17, 2018
@hardl hardl added this to the Backlog_Swinka milestone Oct 17, 2018
@kwiatekus
Copy link
Contributor

Provide convenient configuration attributes for logo and title.
The fav icon and html document title should be changed as well.

@kwiatekus kwiatekus modified the milestones: Backlog_Swinka, Sprint_Swinka_3 Oct 18, 2018
@kwiatekus
Copy link
Contributor

tricky part here : assure its configurable in runtime (console will consume the values for those attributes from an js asset file)

@maxmarkus maxmarkus self-assigned this Oct 22, 2018
@maxmarkus maxmarkus mentioned this issue Oct 23, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxmarkus maxmarkus

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@maxmarkus @korisantosh @kwiatekus @hardl