Configurable logo and title #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le as separate component
maxmarkus
requested review from
antiheld,
dariadomagala-sap,
hardl,
jesusreal,
kwiatekus,
pekura and
y-kkamil
as code owners
…ble-logo-title # Conflicts: # core/examples/luigi-sample-angular/src/app/project/project.component.ts
jesusreal
suggested changes
Oct 24, 2018
…s/luigi into feature/configurable-logo-title
jesusreal
approved these changes
Oct 26, 2018
maxmarkus
requested review from
bszwarc,
kazydek,
klaudiagrz and
tomekpapiernik
as code owners
jesusreal
reviewed
Oct 29, 2018
| @@ -23,7 +23,9 @@ export const processHeaderSettings = component => { | |||
|
|
|||
| // Set Favicon | |||
| if (header.favicon) { | |||
| const isInvalidIcoFile = !header.favicon.split('?')[0].endsWith('.ico'); | |||
| const isInvalidIcoFile = | |||
There was a problem hiding this comment.
Please rename the variable to e.g. isInvalidFormat or isInvalidFaviconFormat
bszwarc
suggested changes
Oct 30, 2018
docs/general-settings.md
Outdated
| **header.logo** defines the top left navigation logo. It has a fixed height of 28px. | ||
| **header.title** defines the top left navigation title. | ||
| **header.favicon** defines the favicon. Requires a standard favicon file with .ico file ending and 16x16px or 32x32px dimensions. |
There was a problem hiding this comment.
Requires a standard favicon file with the `.ico` extension, and 16x16px or 32x32px dimensions.
I would go with extension rather than file ending
docs/general-settings.md
Outdated
| **backdropDisabled** prevents the backdrop layer from covering the top and left navigation when showing modal windows, when set to `true`. By default, the backdrop is enabled and covers the top and left navigation when showing modal windows. To keep the default configuration, set the value to `false` or leave this option unconfigured. |
There was a problem hiding this comment.
When set to `true`, prevents the backdrop layer from covering the top and left navigation when showing modal windows.`
|
Last changes look good to me. Can be merged from my point of view. |
…onfigurable-logo-title
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
* added asynchronous config for settings.header to specify logo, title and favicon * refactored navigation stuff to separate folder, excluded logo and title as separate component * added Promise testcase * hide logo container if there is no logo * fixed tests and added assertions for logo and title * adjusted left header spacing for title only * added docu for configurable logo and title * added support for data:image favicons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added config setting for title, logo and favicon (only .ico files allowed).
Resolves #139