Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong encoding for node params #2896

Closed
MalteBellmann opened this issue Sep 13, 2022 · 0 comments · Fixed by #2901
Closed

Wrong encoding for node params #2896

MalteBellmann opened this issue Sep 13, 2022 · 0 comments · Fixed by #2901
Assignees

Comments

@MalteBellmann
Copy link

Description

When using addNodeParams from a MFE and then using getNodeParams afterwards from the same MFE, the parameters can be encoded wrongly and the output of getNodeParams is different from the input of addNodeParams.

Expected result

The output of getNodeParams is the same as the input of addNodeParams.

Actual result

Spaces in the input to addNodeParams will be transformed to + in the output of getNodeParams. Might also affect other characters.

Steps to reproduce

  1. Call addNodeParams({q: "test abc"})
  2. Wait for context update
  3. Call getNodeParams()
  4. See the result: {q: "test+abc"}

Changing shouldDesanitise to true in getNodeParams has no effect.

Troubleshooting

dxp metadata-registry 476

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants