Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plus sign not decoded correctly when adding and then getting nodeParams #2901

Merged
merged 38 commits into from
Nov 4, 2022

Conversation

wdoberschuetz
Copy link
Contributor

@wdoberschuetz wdoberschuetz commented Sep 19, 2022

Changes proposed in this pull request:

  • replace + with spaces before decodeURIComponent is used

Related issue(s)
Resolves #2896

@wdoberschuetz wdoberschuetz changed the title Add more options to desanitize Add more options to desanitize getNodeParams in helpers.js for the Client Sep 19, 2022
@wdoberschuetz wdoberschuetz added the WIP Work in progress label Oct 12, 2022
@wdoberschuetz wdoberschuetz removed the WIP Work in progress label Oct 12, 2022
@ndricimrr ndricimrr self-assigned this Oct 17, 2022
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it locally and it doesn't seem to yield the expected result.
Screenshot 2022-10-17 at 14 00 44

When I get the node params back I should be getting the same thing that was added with the space and not the % encoded space.

In addition I noticed the newly added %2520 which kinda seems like double encoding from this reference here. I suppose that shouldn't be the case and that you are encoding twice when adding the node params; that might be redundant.

@wdoberschuetz wdoberschuetz added the WIP Work in progress label Oct 17, 2022
@JohannesDoberer JohannesDoberer added the bug Something isn't working label Oct 24, 2022
@wdoberschuetz wdoberschuetz removed the WIP Work in progress label Oct 26, 2022
@wdoberschuetz wdoberschuetz changed the title Add more options to desanitize getNodeParams in helpers.js for the Client '+' (plus) sign not decoded correctly when adding and then getting nodeParams Oct 26, 2022
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be 21 file changes here and the majority of them not related to the issue. Please remove/undo all the unrelated changes
like .gitignore, multiple package-lock.json's package.json changes angular.json changes etc.

@ndricimrr ndricimrr changed the title '+' (plus) sign not decoded correctly when adding and then getting nodeParams Plus sign not decoded correctly when adding and then getting nodeParams Oct 27, 2022
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@wdoberschuetz wdoberschuetz merged commit c62035a into master Nov 4, 2022
@wdoberschuetz wdoberschuetz deleted the 2896-wrong-node-encoding branch November 4, 2022 10:26
This was referenced Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong encoding for node params
3 participants