-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plus sign not decoded correctly when adding and then getting nodeParams #2901
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it locally and it doesn't seem to yield the expected result.
When I get the node params back I should be getting the same thing that was added with the space and not the % encoded space.
In addition I noticed the newly added %2520 which kinda seems like double encoding from this reference here. I suppose that shouldn't be the case and that you are encoding twice when adding the node params; that might be redundant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seem to be 21 file changes here and the majority of them not related to the issue. Please remove/undo all the unrelated changes
like .gitignore, multiple package-lock.json's package.json changes angular.json changes etc.
… into 2896-wrong-node-encoding
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Changes proposed in this pull request:
+
with spaces before decodeURIComponent is usedRelated issue(s)
Resolves #2896