-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to update core URL without mf url change #1111
Merged
maxmarkus
merged 37 commits into
SAP:master
from
maxmarkus:1075-nav-sync-for-virtualtree
Mar 6, 2020
Merged
Ability to update core URL without mf url change #1111
maxmarkus
merged 37 commits into
SAP:master
from
maxmarkus:1075-nav-sync-for-virtualtree
Mar 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-virtualtree # Conflicts: # core/src/navigation/services/navigation.js # core/test/services/navigation.spec.js # docs/luigi-client-api.md # docs/navigation-parameters-reference.md
maxmarkus
added
enhancement
New feature or request
documentation
documentation tasks
labels
Feb 20, 2020
maxmarkus
requested review from
alexandra-simeonova,
hardl,
JohannesDoberer,
marynaKhromova,
pekura and
zarkosimic
as code owners
February 20, 2020 12:55
…luigi into 1075-nav-sync-for-virtualtree
Co-Authored-By: Alexandra Simeonova <49867570+alexandra-simeonova@users.noreply.github.com>
Documentation is moved to PR in #1113 |
…luigi into 1075-nav-sync-for-virtualtree
alexandra-simeonova
approved these changes
Feb 28, 2020
JohannesDoberer
approved these changes
Mar 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
zarkosimic
approved these changes
Mar 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! 👍
…luigi into 1075-nav-sync-for-virtualtree
…ating of side nav
…luigi into 1075-nav-sync-for-virtualtree
…luigi into 1075-nav-sync-for-virtualtree
JohannesDoberer
added a commit
to JohannesDoberer/luigi
that referenced
this pull request
Mar 18, 2020
* master: (26 commits) Add implementations/scenarios (SAP#1116) deleteCache was missing in contextswitcher (SAP#1148) Update type descriptions (SAP#1131) Route change loses context in contextswitcher (SAP#1145) Debug cypress travis - parallel e2e tests (SAP#1121) trying to run npm step only if triggered or pushed to master (SAP#1139) Release v0.7.6 revert docs fiddle (SAP#1138) travis fix travis fix travis fix Release v0.7.6 fix (SAP#1137) Release v0.7.6 (SAP#1136) Refactor resolved node children data management (SAP#1119) Ability to update core URL without mf url change (SAP#1111) Add documentation search (SAP#1123) OIDC profile interceptor (SAP#1129) Added userInfo title to profile item (SAP#1115) Update documentation for examples + consolidate filenames (SAP#1099) Document how to make use of contextUpdateListener (SAP#1109) Document how to set auth storage type (SAP#1096) ... # Conflicts: # .travis.yml # client/luigi-client.d.ts # client/package-lock.json # client/package.json # client/public/package.json # core/examples/luigi-sample-angular/src/assets/sampleexternal.html # core/package-lock.json # core/package.json # core/public/package.json # core/src/core-api/_internalLinkManager.js # core/src/core-api/baseClass.js # core/src/main.js # core/src/navigation/TopNav.html # docs/application-setup.md # docs/getting-started.md # docs/luigi-client-api.md # lerna.json # plugins/auth/src/auth-oidc/index.js # scripts/setup/angular.sh # scripts/setup/no-framework.sh # scripts/setup/openui5.sh # scripts/setup/vue.sh # test/e2e-test-application/e2e/tests/navigation.spec.js # test/e2e-test-application/package.json # test/e2e-test-application/src/app/project/dynamic/dynamic.component.ts # test/e2e-test-application/src/luigi-config/extended/auth.js # website/fiddle/package.json
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
Added `withoutSync()` to `LuigiClient.linkManager()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
withoutSync
method toLuigiClient.linkManager()
.New Tutorials section with example how to use it.
Automatic synching is ommited since it is to expensive to implement all available option.
Should be implemented by the micro frontend developer with a router event listener that updates Luigi Core upon micro-frontend route change.
Documentation is moved to PR in #1113