Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tabnav active state indication #1318

Merged
merged 1 commit into from
May 7, 2020
Merged

Conversation

hardl
Copy link
Contributor

@hardl hardl commented May 7, 2020

No description provided.

@hardl hardl added the bug Something isn't working label May 7, 2020
@hardl hardl added this to the Sprint 10 milestone May 7, 2020
@marynaKhromova marynaKhromova self-assigned this May 7, 2020
@zarkosimic zarkosimic self-assigned this May 7, 2020
@maxmarkus maxmarkus changed the title fix tabnav active state indication Fix tabnav active state indication May 7, 2020
Copy link
Contributor

@marynaKhromova marynaKhromova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@maxmarkus maxmarkus merged commit 5e9d74f into SAP:master May 7, 2020
@maxmarkus maxmarkus deleted the tabnav-fix branch May 7, 2020 16:05
@maxmarkus maxmarkus mentioned this pull request May 7, 2020
JohannesDoberer added a commit that referenced this pull request May 8, 2020
* master:
  added product and context switch to visibility check of three dot menu (#1321)
  Luigi update to v1.1.1 (#1319)
  fix tabnav active state indication (#1318)
  Simple persistent development setup (#1317)
  Link to 0.7.x documentation (#1287)
  Cache improvements for dynamic nodes (#1278)
  update luigi version in docs and adjust layout (#1301)
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants