Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix left-nav flyout #1376

Conversation

zarkosimic
Copy link
Contributor

Fixes #1293

@zarkosimic zarkosimic added the bug Something isn't working label May 28, 2020
@zarkosimic zarkosimic added this to the Sprint 10 milestone May 28, 2020
@ndricimrr ndricimrr self-assigned this May 28, 2020
@JohannesDoberer JohannesDoberer self-assigned this May 28, 2020
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine for me 👍

Just a small suggestion

core/src/navigation/services/semi-collapsed-navigation.js Outdated Show resolved Hide resolved
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@JohannesDoberer JohannesDoberer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 !

@zarkosimic zarkosimic merged commit b15e464 into SAP:master Jun 2, 2020
@zarkosimic zarkosimic deleted the 1293_left_nav_flyout_and_navigation_component_variables branch June 2, 2020 07:54
@ndricimrr ndricimrr mentioned this pull request Jun 4, 2020
JohannesDoberer added a commit that referenced this pull request Jun 9, 2020
* master:
  Update dependencies from GitHub (#1395)
  Update dependency in Landingpage (#1387)
  update versions for fiddle and website (#1391)
  New FAQ - How can I style the Luigi core elements? (#1354)
  add Out of the box section to the About page (#1365)
  Release v1.2.1  (#1385)
  Add onNodeChange hook (#1316)
  Fix client half init state (#1356)
  fix title propagation issue (#1374)
  Add testing production build capability (#1367)
  removing iframe properly (#1364)
  add viewport meta tag for devtools (#1379)
  Show warning if sendCustomMessage id does not exist (#1351)
  Fix left-nav flyout (#1376)
  ContextSwitcher bugfix (#1368)
  fix for fiddle styling issue
  style according to new FD Styles mock examples (#1353)
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Jun 9, 2020
* feature-globalsearch:
  Update dependencies from GitHub (SAP#1395)
  Update dependency in Landingpage (SAP#1387)
  update versions for fiddle and website (SAP#1391)
  New FAQ - How can I style the Luigi core elements? (SAP#1354)
  add Out of the box section to the About page (SAP#1365)
  Release v1.2.1  (SAP#1385)
  Add onNodeChange hook (SAP#1316)
  Fix client half init state (SAP#1356)
  fix title propagation issue (SAP#1374)
  Add testing production build capability (SAP#1367)
  removing iframe properly (SAP#1364)
  add viewport meta tag for devtools (SAP#1379)
  Show warning if sendCustomMessage id does not exist (SAP#1351)
  Fix left-nav flyout (SAP#1376)
  ContextSwitcher bugfix (SAP#1368)
  fix for fiddle styling issue
  style according to new FD Styles mock examples (SAP#1353)
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

left-nav flyout and navigation component using two different state variables
3 participants