Fix navigation with and without params on the same node #1441
+34
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndricimrr
requested review from
alexandra-simeonova,
hardl,
JohannesDoberer,
marynaKhromova,
maxmarkus,
pekura and
zarkosimic
as code owners
…igi into 1412-fix-navigation-wparams
maxmarkus
approved these changes
Jul 6, 2020
|
|
JohannesDoberer
added a commit
to JohannesDoberer/luigi
that referenced
this pull request
Jul 13, 2020
* feature-globalsearch: Bump npm-registry-fetch in /core/examples/luigi-example-angular (SAP#1473) Bump npm from 6.14.4 to 6.14.6 in /client (SAP#1472) Check plugin nightly releases (SAP#1454) Add Uliana and Jimmy to codeowners (SAP#1479) Update fiddle to 1.2.4 (SAP#1460) Fix navigation with and without params on the same node (SAP#1441) Update version of FD for core and E2E App to 0.10.0 (SAP#1401) Change code owners (SAP#1464)
Merged
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
* fix navigation w params * small fix * fix e2e-test to check back and forth Co-authored-by: JohannesDoberer <johannes.doberer@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Navigating from http://localhost:4200/settings to
http://localhost:4200/settings?~foo=bar does not work and vice versa.
Parameters in url will stay or not and also the section of the parameters in microfrontend will stay or not displayed.
Changes proposed in this pull request:
Fixed
How to Test:
In browser console run the following
Luigi.navigation().withParams({'luigi':'phteven'}).navigate('/settings');and afterwardsLuigi.navigation().navigate('/settings');and the same vice versa.Also changing the parameters will not applied in MF.
Fixes #1412