Fix logout label #1453
Merged
Fix logout label #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxmarkus
requested review from
alexandra-simeonova,
hardl,
JohannesDoberer,
marynaKhromova,
pekura and
zarkosimic
as code owners
UlianaMunich
reviewed
Jul 2, 2020
core/src/Authorization.html
Outdated
| AuthLayerSvc.setProfileLogoutFn(profileLogoutfn); | ||
| } | ||
| profileLogoutFnDefined = true; | ||
| AuthLayerSvc.setProfileLogoutFn(profileLogoutfn); |
There was a problem hiding this comment.
I think setProfileLogoutFn should get logoutItem.customLogoutFn as parameter otherwise profileLogoutfn is not defined. See removed line 176
Merged
JohannesDoberer
added a commit
that referenced
this pull request
Jul 6, 2020
* master: (21 commits) style the mobile avigation for Documentation (#1452) allow hash and section deeplinks (#1447) Add link to blogs (#1442) Release v1.2.4 (#1457) Fix logout label (#1453) adds a check if persisted collapsible state is closed and prevent persistion on resize (#1431) update links (#1445) 1381 update version of Fundamental Styles on Fiddle to 0.10.0 (#1414) 1381 update version of Fundamental Styles on Fiddle to 0.10.0 (#1414) 1381 update version of Fundamental Styles on Fiddle to 0.10.0 (#1414) 1381 update version of Fundamental Styles on Fiddle to 0.10.0 (#1414) redirect for blog on landingpage Add blog to website (#1439) release v1.2.3 (#1437) remove non-working code (#1436) Release v1.2.2 (#1435) fix double frame (#1433) Added showLabel attribute to node for top level nav (#1429) Strip Documentation in Changelog generation (#1404) Feature/badge counter (#1409) ...
JohannesDoberer
added a commit
to JohannesDoberer/luigi
that referenced
this pull request
Jul 6, 2020
* feature-globalsearch: (21 commits) style the mobile avigation for Documentation (SAP#1452) allow hash and section deeplinks (SAP#1447) Add link to blogs (SAP#1442) Release v1.2.4 (SAP#1457) Fix logout label (SAP#1453) adds a check if persisted collapsible state is closed and prevent persistion on resize (SAP#1431) update links (SAP#1445) 1381 update version of Fundamental Styles on Fiddle to 0.10.0 (SAP#1414) 1381 update version of Fundamental Styles on Fiddle to 0.10.0 (SAP#1414) 1381 update version of Fundamental Styles on Fiddle to 0.10.0 (SAP#1414) 1381 update version of Fundamental Styles on Fiddle to 0.10.0 (SAP#1414) redirect for blog on landingpage Add blog to website (SAP#1439) release v1.2.3 (SAP#1437) remove non-working code (SAP#1436) Release v1.2.2 (SAP#1435) fix double frame (SAP#1433) Added showLabel attribute to node for top level nav (SAP#1429) Strip Documentation in Changelog generation (SAP#1404) Feature/badge counter (SAP#1409) ...
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1448