fix issues with brken left side nav in semiCollapsed mode and scroller #1633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UlianaMunich
requested review from
alexandra-simeonova,
hardl,
JohannesDoberer,
maxmarkus,
ndricimrr and
stanleychh
as code owners
ndricimrr
approved these changes
Sep 25, 2020
JohannesDoberer
approved these changes
Sep 29, 2020
JohannesDoberer
added a commit
to JohannesDoberer/luigi
that referenced
this pull request
Oct 12, 2020
* master: bump the versions of luigi packages (SAP#1649) Add NodeAccessibilityResolver tip to auth document (SAP#1639) Adding funtionality to logout the user dynamically without the need to click the logout button (SAP#1631) fix issues with brken left side nav in semiCollapsed mode and scroller (SAP#1633) Add ids and aria-labeldby to the nested lists (SAP#1607) fixed nav hrefs for hash routing (SAP#1640)
Merged
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1586
before ttesting please set responsiveNavigation = 'semiCollapsible';