Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CM fixes #1755

Merged
merged 10 commits into from
Dec 4, 2020
Merged

CM fixes #1755

merged 10 commits into from
Dec 4, 2020

Conversation

JohannesDoberer
Copy link
Contributor

Fixes #1747

@JohannesDoberer JohannesDoberer added security/high Related to CVSSv3 security rating https://www.first.org/cvss/calculator/3.0 internal Stuff like NFRs, CI pipeline labels Dec 3, 2020
@JohannesDoberer JohannesDoberer added this to the Sprint 14 milestone Dec 3, 2020
@JohannesDoberer
Merge branch 'master' into cm-xss
5b825de 
* master:
  Feature angular supporting library (SAP#1756)
  Website security (SAP#1742)
@stanleychh stanleychh self-assigned this Dec 4, 2020
stanleychh
stanleychh approved these changes Dec 4, 2020
View reviewed changes
Copy link
Contributor

@stanleychh stanleychh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the cleanup comment, the rest looks good to me.

UlianaMunich
UlianaMunich approved these changes Dec 4, 2020
View reviewed changes
Copy link
Contributor

@UlianaMunich UlianaMunich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works well!

@UlianaMunich UlianaMunich self-assigned this Dec 4, 2020
@JohannesDoberer JohannesDoberer merged commit 58a1770 into SAP:master Dec 4, 2020
@JohannesDoberer JohannesDoberer deleted the cm-xss branch December 4, 2020 10:39
JohannesDoberer added a commit that referenced this pull request Dec 8, 2020
@JohannesDoberer
Merge branch 'master' into feature-user-settings
fb7d89f 
* master:
  release-v1.7.0 (#1759)
  CM fixes (#1755)
  changes for night build (#1757)
  Feature angular supporting library (#1756)
  Website security (#1742)
  fixed case sensitivity issue in luigi element
  Feature wc support (#1751)
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Dec 8, 2020
@JohannesDoberer
Merge branch 'feature-user-settings' into dialog-box-for-user-settings
a6b8966 
* feature-user-settings:
  release-v1.7.0 (SAP#1759)
  CM fixes (SAP#1755)
  changes for night build (SAP#1757)
  Feature angular supporting library (SAP#1756)
  Website security (SAP#1742)
  fixed case sensitivity issue in luigi element
  Feature wc support (SAP#1751)

# Conflicts:
#	core/package.json
#	core/src/utilities/helpers/index.js
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@JohannesDoberer
CM fixes (SAP#1755)
4b27a35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanleychh stanleychh stanleychh approved these changes

@UlianaMunich UlianaMunich UlianaMunich approved these changes

@alexandra-simeonova alexandra-simeonova Awaiting requested review from alexandra-simeonova

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@legteodav legteodav Awaiting requested review from legteodav

@maxmarkus maxmarkus Awaiting requested review from maxmarkus

@ndricimrr ndricimrr Awaiting requested review from ndricimrr ndricimrr is a code owner

Assignees

@UlianaMunich UlianaMunich

@stanleychh stanleychh

Labels
internal Stuff like NFRs, CI pipeline security/high Related to CVSSv3 security rating https://www.first.org/cvss/calculator/3.0
Projects
None yet
Milestone
Sprint 14
Development

Successfully merging this pull request may close these issues.

CM: Client Dom xss
3 participants
@JohannesDoberer @UlianaMunich @stanleychh