Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make navigateIframe and prepareInternalData functions be async #1799

Merged
merged 3 commits into from
Jan 13, 2021
Merged

Make navigateIframe and prepareInternalData functions be async #1799

merged 3 commits into from
Jan 13, 2021
+29 −33

Conversation

stanleychh
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Make navigateIframe and prepareInternalData functions be asynchronous
  • MFs will get corresponding userSettings object while switching around different userSettingGroup

Related issue(s)
Fixes #1797

@stanleychh stanleychh added this to the Sprint 15 milestone Jan 5, 2021
@stanleychh stanleychh added the enhancement New feature or request label Jan 5, 2021
@legteodav legteodav self-assigned this Jan 5, 2021
@JohannesDoberer JohannesDoberer self-assigned this Jan 11, 2021
@stanleychh stanleychh merged commit 927adf9 into SAP:master Jan 13, 2021
@stanleychh stanleychh deleted the 1797-prepareInternalData-async branch January 13, 2021 10:39
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Jan 13, 2021
@JohannesDoberer
Merge branch 'master' into custom-mf-for-user-settings
c2a438a 
* master:
  Make navigateIframe and prepareInternalData functions be async (SAP#1799)

# Conflicts:
#	core/src/App.html
@ndricimrr ndricimrr mentioned this pull request Jan 21, 2021
Merged
stanleychh added a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@stanleychh
Make navigateIframe and prepareInternalData functions be async (SAP#1799
913b9a6 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legteodav legteodav legteodav approved these changes

@JohannesDoberer JohannesDoberer JohannesDoberer approved these changes

@alexandra-simeonova alexandra-simeonova Awaiting requested review from alexandra-simeonova

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@maxmarkus maxmarkus Awaiting requested review from maxmarkus

@ndricimrr ndricimrr Awaiting requested review from ndricimrr ndricimrr is a code owner

@UlianaMunich UlianaMunich Awaiting requested review from UlianaMunich

Assignees

@legteodav legteodav

@JohannesDoberer JohannesDoberer

Labels
enhancement New feature or request
Projects
None yet
Milestone
Sprint 15
Development

Successfully merging this pull request may close these issues.

Make navigateIframe and prepareInternalData functions be asynchronous
3 participants
@stanleychh @legteodav @JohannesDoberer