Add documentation about breaking changes in Luigi 1.9.0 due to FD Sty… #1857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UlianaMunich
requested review from
alexandra-simeonova,
hardl,
JohannesDoberer,
legteodav,
maxmarkus,
ndricimrr and
stanleychh
as code owners
legteodav
approved these changes
Feb 1, 2021
JohannesDoberer
approved these changes
Feb 1, 2021
docs/versions.md
Outdated
| @@ -89,6 +89,8 @@ With Luigi version v1.3.0, the new v0.10.0 of Fundamental Library Styles were in | |||
|
|
|||
| With Luigi v1.4.0, the new v0.11.0 of Fundamental Library Styles were included. As a result, there were breaking changes to the Luigi Alerts. The classes `fd-overlay fd-overlay--message-strip` were removed from Fundamental Library Styles and we added a new class `luigi-alert--overlay` to keep the same look and feel as in the past. You can see all breaking changes of Fundamental Library Styles [here](https://github.com/SAP/fundamental-styles/wiki/Breaking-Changes#0110). | |||
|
|
|||
| With Luigi v1.9.0, the new v0.14.0 of Fundamental Library Styles were included. Its pervious v0.12.0 led to having breaking changes in the Luigi left side navigation and the shellbar. All icons vere moved out from pseudo-classes into a dedicated tag `<i class="sap-icon sap-icon--{modifier}"></i>` under the button. You can see all breaking changes of Fundamental Library Styles v0.12.0 [here](https://github.com/SAP/fundamental-styles/releases?after=v0.12.1-rc.7). | |||
There was a problem hiding this comment.
All icons vere moved => All icons were moved
Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com>
alexandra-simeonova
approved these changes
Feb 2, 2021
JohannesDoberer
added a commit
to JohannesDoberer/luigi
that referenced
this pull request
Feb 3, 2021
…esDoberer/luigi into bug-fix-custom-mf-on-usersettings * 'bug-fix-custom-mf-on-usersettings' of github.com:JohannesDoberer/luigi: Add documentation about breaking changes in Luigi 1.9.0 due to FD Sty… (SAP#1857)
JohannesDoberer
added a commit
to JohannesDoberer/luigi
that referenced
this pull request
Feb 4, 2021
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation breaking changes in Luigi v1.9.0 due to the update from FD Styles 0.11.0 to 0.14.0
Fixes #1855