Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend options of enum type in user settings #2049

Merged
merged 26 commits into from
Jun 7, 2021
Merged

Extend options of enum type in user settings #2049

merged 26 commits into from
Jun 7, 2021

Conversation

JohannesDoberer
Copy link
Contributor

@JohannesDoberer JohannesDoberer commented May 25, 2021 •
edited by ndricimrr
Loading

Changes proposed in this pull request:

  • options array of type enum in user settings can also have objects as entries

Fixes #2041

@JohannesDoberer
extend options
a063466
@JohannesDoberer
Merge branch 'master' into extend-options
6607a9a 
* master:
  fix (SAP#2043)
  Bump hosted-git-info from 2.8.4 to 2.8.9 (SAP#2018)
  Update Fundamental Styles library from v0.14.0 to v0.17.0 (SAP#1996)
  Bump lodash version of scripts/package.json (SAP#2031)
  Global nav adjustments (SAP#2035)
  Fix set document title issue when no header or title provided
  Fix misplaced content area on mobile if globalnav enabled
  Bump Fundamental Styles v0.17.0 from v0.11.0 in Fiddle (SAP#2027)
  Bump hosted-git-info from 2.8.5 to 2.8.9 in /core (SAP#2019)
  Bump url-parse in /core/examples/luigi-example-angular (SAP#2017)
  Udpdate versionc of vue-cli to 4.5.13 too fix high security ussues with sub-dependencies (SAP#2028)
@JohannesDoberer
no message
26184f0
@JohannesDoberer JohannesDoberer added the enhancement New feature or request label May 25, 2021
@JohannesDoberer JohannesDoberer added this to the Sprint 19 milestone May 25, 2021
@ndricimrr ndricimrr self-assigned this May 26, 2021
@ndricimrr
Copy link
Contributor

@JohannesDoberer
Could you run in the root folder :
npm run full-code-quality-prettier
Might need to npm install if not done previously.
and just commit the result?

There are some non-prettified stuff in the PR, or I think it is prettified differently from what is expected, and many changes are showing

@JohannesDoberer
prettier
fa9609c
@JohannesDoberer
Merge branch 'extend-options' of github.com:JohannesDoberer/luigi int…
97d3d1c 
…o extend-options

* 'extend-options' of github.com:JohannesDoberer/luigi:
  Bump elliptic from 6.5.2 to 6.5.4 in /website/landingpage/dev (SAP#2060)
  Bump hosted-git-info from 2.8.2 to 2.8.9 in /website/landingpage/dev (SAP#2053)
  Bump bl from 1.2.2 to 1.2.3 in /website/landingpage/dev (SAP#2055)
  Bump ssri from 6.0.1 to 6.0.2 in /website/landingpage/dev (SAP#2058)
  Bump browserslist in /core/examples/luigi-example-vue (SAP#2050)
  Bump handlebars from 4.7.6 to 4.7.7 in /website/landingpage/dev (SAP#2054)
  Bump y18n from 3.2.1 to 3.2.2 in /website/landingpage/dev (SAP#2059)
  Bump lodash from 4.17.15 to 4.17.21 in /website/landingpage/dev (SAP#2056)
  Bump browserslist from 4.12.0 to 4.16.6 in /website/landingpage/dev (SAP#2057)
  Bump browserslist from 4.7.0 to 4.16.6 in /website/docs (SAP#2051)
  Bump browserslist in /core/examples/luigi-example-angular (SAP#2052)
  Bump browserslist from 4.8.6 to 4.16.6 in /core (SAP#2047)
  Bump browserslist from 4.11.1 to 4.16.6 in /scripts (SAP#2048)
@JohannesDoberer
Merge branch 'master' into extend-options
62e28ec
@JohannesDoberer
Merge branch 'master' into extend-options
f5f3f2f
ndricimrr
ndricimrr reviewed May 26, 2021
View reviewed changes
Copy link
Contributor

@ndricimrr ndricimrr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functionality seems to be working fine for me 👍 . Added one code suggestion if you think it makes sense.

Also, I see that the get functions are returning a string instead of the object for both client and core api functions, when u chose an object as language. So I cannot get the value from the object:
Screen Shot 2021-05-26 at 19 24 29

If you check the
https://docs.luigi-project.io/docs/luigi-core-api/?section=getcurrentlocale

getCurrentLocale
Gets the current locale.
Returns string current locale

So, maybe we also need to modify these two functions to return either Object or string in this PR or in a followup ticket?

core/src/UserSettingsEditor.html Outdated Show resolved Hide resolved
@JohannesDoberer
suggestion applied
fa28035
@JohannesDoberer
Merge branch 'extend-options' of github.com:JohannesDoberer/luigi int…
6475132 
…o extend-options

* 'extend-options' of github.com:JohannesDoberer/luigi:
  Bump browserslist from 4.6.0 to 4.16.6 in /client (SAP#2046)
  Bump ini from 1.3.5 to 1.3.8 in /website/landingpage/dev (SAP#2061)
JohannesDoberer and others added 2 commits May 28, 2021 07:58
ndricimrr
ndricimrr reviewed May 28, 2021
View reviewed changes
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested again and it works well. Code looks good

core/src/UserSettingsEditor.html Outdated Show resolved Hide resolved
@JohannesDoberer @ndricimrr
Update core/src/UserSettingsEditor.html
94eda00 
Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>
@JohannesDoberer JohannesDoberer added the WIP Work in progress label Jun 1, 2021
@JohannesDoberer
Merge branch 'extend-options' of github.com:JohannesDoberer/luigi int…
9a6fbe3 
…o extend-options

* 'extend-options' of github.com:JohannesDoberer/luigi:
  Update core/src/UserSettingsEditor.html
  Fix security vulnerability (SAP#2045)
  Bump dns-packet from 1.3.1 to 1.3.4 in /core/examples/luigi-example-vue (SAP#2062)
  Bump dns-packet in /core/examples/luigi-example-angular (SAP#2063)
  Update core/src/UserSettingsEditor.html
  Update packages of remark to fix securty issues on github (SAP#2033)
  docu improvements (SAP#2044)

# Conflicts:
#	core/src/UserSettingsEditor.html
#	docs/user-settings.md
@JohannesDoberer
test fix
7254cca
@JohannesDoberer
Merge branch 'master' into extend-options
dd1a01c
@JohannesDoberer
docu
d0f4cc3
@JohannesDoberer
Merge branch 'extend-options' of github.com:JohannesDoberer/luigi int…
37f8c18 
…o extend-options

* 'extend-options' of github.com:JohannesDoberer/luigi:
  path-exists fix (SAP#2065)
  Luigi context emulation in e2e for microfrontends (SAP#2040)
@JohannesDoberer JohannesDoberer removed the WIP Work in progress label Jun 1, 2021
@JohannesDoberer JohannesDoberer added the documentation documentation tasks label Jun 2, 2021
ndricimrr
ndricimrr reviewed Jun 2, 2021
View reviewed changes
Copy link
Contributor

@ndricimrr ndricimrr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Please run npm run full-code-quality-prettier on root folder as there are many non-prettified changes. Somehow I think the commit hook either is not working or is skipped on your environment.

@JohannesDoberer JohannesDoberer merged commit f24d5f9 into SAP:master Jun 7, 2021
@JohannesDoberer JohannesDoberer deleted the extend-options branch June 7, 2021 12:15
@JohannesDoberer JohannesDoberer mentioned this pull request Jun 7, 2021
Merged
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@JohannesDoberer
Extend options of enum type in user settings (SAP#2049)
fbf6507
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndricimrr ndricimrr ndricimrr approved these changes

@alexandra-simeonova alexandra-simeonova alexandra-simeonova approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@legteodav legteodav Awaiting requested review from legteodav

@maxmarkus maxmarkus Awaiting requested review from maxmarkus

@UlianaMunich UlianaMunich Awaiting requested review from UlianaMunich

@stanleychh stanleychh Awaiting requested review from stanleychh

Assignees

@ndricimrr ndricimrr

Labels
documentation documentation tasks dxp enhancement New feature or request
Projects
None yet
Milestone
Sprint 19
Development

Successfully merging this pull request may close these issues.

Extend enum type in user settings
4 participants
@JohannesDoberer @ndricimrr @stanleychh @alexandra-simeonova