Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Logo and App title an anchor in Shellbar #2081

Merged
merged 9 commits into from
Jun 16, 2021
Merged

Make Logo and App title an anchor in Shellbar #2081

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
11f3443
Make Logo and App tile an anchor in Shellbar
UlianaMunich Jun 9, 2021
fdbbd0e
Merge branch 'master' into 2079-make-anchor-logo-and-apptitle
UlianaMunich Jun 9, 2021
9af3490
Merge branch 'master' into 2079-make-anchor-logo-and-apptitle
UlianaMunich Jun 9, 2021
7befb73
Merge branch 'master' into 2079-make-anchor-logo-and-apptitle
UlianaMunich Jun 11, 2021
4d6fded
Add navHref to the Shellbar Logo and App title when needed
UlianaMunich Jun 15, 2021
15befd6
Merge branch 'master' into 2079-make-anchor-logo-and-apptitle
UlianaMunich Jun 15, 2021
18fba57
make a workaround to not introduce breaking changes, fix issue with d…
UlianaMunich Jun 15, 2021
2b9e20d
Merge branch '2079-make-anchor-logo-and-apptitle' of github.com:Ulian…
UlianaMunich Jun 15, 2021
3869cff
fix broken test with product switcher
UlianaMunich Jun 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 29 additions & 4 deletions core/src/navigation/LogoTitle.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,15 @@
{#if LuigiConfig.getConfigBooleanValue('navigation.addNavHrefs')}
<a
class="fd-shellbar__logo { !hasLogo ? 'fd-shellbar__logo--image-replaced' : '' } { hasLogo ? 'lui-customlogo' : ''}"
aria-label="SAP"
on:click|preventDefault="{() => goTo('/')}"
href="/"
>
{#if hasLogo}
<img data-testid="luigi-topnav-logo" bind:this="{logo}" alt="SAP" />
{/if}
</a>
{:else}
<span
class="fd-shellbar__logo { !hasLogo ? 'fd-shellbar__logo--image-replaced' : '' } { hasLogo ? 'lui-customlogo' : ''}"
aria-label="SAP"
Expand All @@ -7,14 +19,25 @@
<img data-testid="luigi-topnav-logo" bind:this="{logo}" alt="SAP" />
{/if}
</span>
{#if title} {#if !hasApps}
{/if} {#if title} {#if !hasApps} {#if
LuigiConfig.getConfigBooleanValue('navigation.addNavHrefs')}
<a
class="fd-shellbar__title lui-shellbar-single-app-title"
data-testid="luigi-topnav-title"
on:click|preventDefault="{() => goTo('/')}"
href="/"
>
{$getTranslation(title)}
</a>
{:else}
<span
class="fd-shellbar__title lui-shellbar-single-app-title"
data-testid="luigi-topnav-title"
on:click="{() => goTo('/')}"
>{$getTranslation(title)}</span
>
{:else}
{$getTranslation(title)}
</span>
{/if}{:else}
<div class="fd-popover">
<div class="fd-popover__control" on:click|stopPropagation="{() => {}}">
<button
Expand Down Expand Up @@ -70,12 +93,13 @@
</div>
{/if} {#if subTitle}
<div class="fd-shellbar__subtitle">{$getTranslation(subTitle)}</div>
{/if} {/if}
{/if}{/if}
<script>
import { beforeUpdate, createEventDispatcher, onMount, getContext } from 'svelte';
import * as Header from './services/header';
import { Routing } from '../services/routing';
import { NavigationHelpers, RoutingHelpers } from '../utilities/helpers';
import { LuigiConfig } from '../core-api';

const dispatch = createEventDispatcher();

Expand Down Expand Up @@ -224,6 +248,7 @@
.lui-shellbar-single-app-title {
padding: 0 0.625rem;
max-width: 50vw;
text-decoration: none;
}

.lui-app-switch {
Expand Down