Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK #2075 | Add user settings placeholder #2089

Merged
merged 11 commits into from
Jun 18, 2021

Conversation

rafalgamon
Copy link
Contributor

Description

Changes proposed in this pull request:

Related issue(s)
Fixes #2075

@CLAassistant
Copy link

CLAassistant commented Jun 13, 2021

CLA assistant check
All committers have signed the CLA.

@ndricimrr ndricimrr added this to the Sprint 20 milestone Jun 14, 2021
@JohannesDoberer JohannesDoberer self-assigned this Jun 14, 2021
Copy link
Contributor

@JohannesDoberer JohannesDoberer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add an e2e test?

core/src/UserSettingsEditor.html Outdated Show resolved Hide resolved
core/src/UserSettingsEditor.html Outdated Show resolved Hide resolved
Copy link
Contributor

@JohannesDoberer JohannesDoberer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 !

@JohannesDoberer JohannesDoberer merged commit cca5153 into SAP:master Jun 18, 2021
@JohannesDoberer JohannesDoberer added the enhancement New feature or request label Jun 21, 2021
@JohannesDoberer JohannesDoberer mentioned this pull request Jun 21, 2021
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants