Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent to open a node w/o children and empty viewUrl #2139

Merged
merged 6 commits into from
Jul 14, 2021
Merged

Prevent to open a node w/o children and empty viewUrl #2139

merged 6 commits into from
Jul 14, 2021

Conversation

stanleychh
Copy link
Contributor

Changes proposed in this pull request:

  • Check if the node has an empty viewUrl
  • Check if the node has children
  • Introduce a new node intendToHaveEmptyViewUrl which is a boolean type.

Fixes #2130

@stanleychh stanleychh added this to the Sprint 20 milestone Jul 7, 2021
@stanleychh stanleychh added the bug Something isn't working label Jul 7, 2021
@stanleychh stanleychh marked this pull request as ready for review July 7, 2021 13:21
@stanleychh stanleychh added the documentation documentation tasks label Jul 7, 2021
@stanleychh @alexandra-simeonova
Update docs/navigation-parameters-reference.md
ed39223 
Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com>
@JohannesDoberer JohannesDoberer self-assigned this Jul 13, 2021
@JohannesDoberer JohannesDoberer merged commit 3a71bcc into SAP:master Jul 14, 2021
@JohannesDoberer JohannesDoberer mentioned this pull request Jul 14, 2021
Merged
@stanleychh stanleychh deleted the 2130-empty-viewUrl-node branch July 15, 2021 07:26
stanleychh added a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@stanleychh
Prevent to open a node w/o children and empty viewUrl (SAP#2139)
6f654e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandra-simeonova alexandra-simeonova alexandra-simeonova approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@JohannesDoberer JohannesDoberer Awaiting requested review from JohannesDoberer JohannesDoberer is a code owner

@ndricimrr ndricimrr Awaiting requested review from ndricimrr ndricimrr is a code owner

@rafalgamon rafalgamon Awaiting requested review from rafalgamon

@UlianaMunich UlianaMunich Awaiting requested review from UlianaMunich

@wdoberschuetz wdoberschuetz Awaiting requested review from wdoberschuetz

Assignees

@JohannesDoberer JohannesDoberer

Labels
bug Something isn't working documentation documentation tasks
Projects
None yet
Milestone
Sprint 20
Development

Successfully merging this pull request may close these issues.

Prevent to open a node w/o children and empty viewUrl
3 participants
@stanleychh @alexandra-simeonova @JohannesDoberer