2120: Add navHref possibility for profile dropdown #2168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdoberschuetz
requested review from
alexandra-simeonova,
hardl,
JohannesDoberer,
ndricimrr,
rafalgamon,
stanleychh and
UlianaMunich
as code owners
UlianaMunich
suggested changes
Jul 27, 2021
There was a problem hiding this comment.
Please update href attribute for every custom entity of the profile dropdown such as: Login/Lgout HTML element, user settings.
In addition to it, please switch Profile Menu to use "Fiori3" profileType and Authorization.html as result needs to be updated as well.
UlianaMunich
reviewed
Aug 2, 2021
UlianaMunich
approved these changes
Aug 2, 2021
Merged
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Related issue(s)
#2120 AddNavHref support for profile dropdown