Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Routing core api #2207

Merged
merged 41 commits into from
Aug 31, 2021
Merged

Routing core api #2207

merged 41 commits into from
Aug 31, 2021

Conversation

JohannesDoberer
Copy link
Contributor

Fixes #2176

@JohannesDoberer JohannesDoberer added the WIP Work in progress label Aug 11, 2021
@JohannesDoberer JohannesDoberer added this to the Sprint 21 milestone Aug 11, 2021
@JohannesDoberer JohannesDoberer added enhancement New feature or request and removed WIP Work in progress labels Aug 12, 2021
alexandra-simeonova
alexandra-simeonova reviewed Aug 13, 2021
View reviewed changes
docs/luigi-core-api.md Outdated Show resolved Hide resolved
docs/luigi-core-api.md Outdated Show resolved Hide resolved
docs/luigi-core-api.md Outdated Show resolved Hide resolved
@alexandra-simeonova alexandra-simeonova self-assigned this Aug 13, 2021
JohannesDoberer and others added 4 commits August 16, 2021 09:41
@JohannesDoberer @alexandra-simeonova
Update docs/luigi-core-api.md
07158a7 
Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com>
@JohannesDoberer @alexandra-simeonova
Update docs/luigi-core-api.md
443e629 
Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com>
@JohannesDoberer @alexandra-simeonova
Update docs/luigi-core-api.md
ea33b6f 
Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com>
@JohannesDoberer
Merge branch 'master' into routing-core-api
ec38ac4
alexandra-simeonova
alexandra-simeonova reviewed Aug 17, 2021
View reviewed changes
Copy link
Contributor

@alexandra-simeonova alexandra-simeonova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I forgot it's not enough to only edit the .md file because the document is autogenerated 😄

core/src/core-api/routing.js Outdated Show resolved Hide resolved
core/src/core-api/routing.js Outdated Show resolved Hide resolved
@stanleychh
Copy link
Contributor

@JohannesDoberer, could you please check prettier? It seems eslint did not work from your side.

JohannesDoberer and others added 4 commits August 18, 2021 07:50
@JohannesDoberer @alexandra-simeonova
Update core/src/core-api/routing.js
db9ee70 
Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com>
@JohannesDoberer @alexandra-simeonova
Update core/src/core-api/routing.js
da9994b 
Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com>
@JohannesDoberer
prettier
152e21e
@JohannesDoberer
prettier
7148edf
stanleychh
stanleychh reviewed Aug 24, 2021
View reviewed changes
core/src/core-api/routing.js Outdated Show resolved Hide resolved
core/src/core-api/routing.js Outdated Show resolved Hide resolved
JohannesDoberer and others added 2 commits August 24, 2021 12:32
@JohannesDoberer @stanleychh
Update core/src/core-api/routing.js
c508e90 
Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com>
@JohannesDoberer @stanleychh
Update core/src/core-api/routing.js
4af6e07 
Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com>
@JohannesDoberer
Merge branch 'master' into routing-core-api
3705265 
# Conflicts:
#	docs/luigi-client-api.md
#	docs/luigi-core-api.md
@JohannesDoberer JohannesDoberer merged commit 77dcde9 into SAP:master Aug 31, 2021
@JohannesDoberer JohannesDoberer deleted the routing-core-api branch August 31, 2021 08:00
@ndricimrr ndricimrr mentioned this pull request Sep 9, 2021
Merged
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@JohannesDoberer
Routing core api (SAP#2207)
aeab340
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanleychh stanleychh stanleychh approved these changes

@alexandra-simeonova alexandra-simeonova alexandra-simeonova approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@ndricimrr ndricimrr Awaiting requested review from ndricimrr ndricimrr is a code owner

@rafalgamon rafalgamon Awaiting requested review from rafalgamon

@UlianaMunich UlianaMunich Awaiting requested review from UlianaMunich

@wdoberschuetz wdoberschuetz Awaiting requested review from wdoberschuetz

Assignees

@stanleychh stanleychh

@alexandra-simeonova alexandra-simeonova

Labels
enhancement New feature or request
Projects
None yet
Milestone
Sprint 21
Development

Successfully merging this pull request may close these issues.

core api for query params
4 participants
@JohannesDoberer @stanleychh @alexandra-simeonova @UlianaMunich