Fixed resizing main iframe container if a drawer is opened #2294
+134
−16,501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafalgamon
requested review from
alexandra-simeonova,
hardl,
JohannesDoberer,
ndricimrr,
stanleychh,
UlianaMunich and
wdoberschuetz
as code owners
JohannesDoberer
requested changes
Sep 30, 2021
There was a problem hiding this comment.
Works as expected 👍 , but please move resizeMainIframe to drawer settings object.
Core api : https://github.com/SAP/luigi/blob/master/core/src/core-api/navigation.js#L98
Client api: https://github.com/SAP/luigi/blob/master/client/src/linkManager.js#L169
|
Please name it overlap: true/false instead of resizeMainIFrame because the main content view can also be an webcomponent. One additional issue:
|
JohannesDoberer
approved these changes
Oct 18, 2021
Merged
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request: