Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Luigi Core/Client in examples Apps #2336

Merged
merged 6 commits into from
Nov 2, 2021
Merged

Update Luigi Core/Client in examples Apps #2336

merged 6 commits into from
Nov 2, 2021

Conversation

UlianaMunich
Copy link
Contributor

Fxes #1876

@JohannesDoberer JohannesDoberer added this to the Sprint 21 milestone Oct 22, 2021
@JohannesDoberer JohannesDoberer added the enhancement New feature or request label Oct 22, 2021
@JohannesDoberer JohannesDoberer self-assigned this Oct 27, 2021
@UlianaMunich
Copy link
Contributor Author

UlianaMunich commented Oct 29, 2021 •
edited
Loading

I tested a lot of attributes, all look good, except of

 navigation: {
    validWebcomponentUrls:['https\:\/\/YOURPROJECT\.gitlab\.io\/.?']
  }

looks like it is not getting an update on the flight. Need to dig in after the vacation

JohannesDoberer
JohannesDoberer approved these changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@JohannesDoberer JohannesDoberer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JohannesDoberer JohannesDoberer merged commit 058560d into SAP:master Nov 2, 2021
@JohannesDoberer JohannesDoberer mentioned this pull request Nov 2, 2021
Merged
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@UlianaMunich
Update Luigi Core/Client in examples Apps (SAP#2336)
e61b986
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohannesDoberer JohannesDoberer JohannesDoberer approved these changes

@alexandra-simeonova alexandra-simeonova Awaiting requested review from alexandra-simeonova

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@ndricimrr ndricimrr Awaiting requested review from ndricimrr ndricimrr is a code owner

@rafalgamon rafalgamon Awaiting requested review from rafalgamon

@stanleychh stanleychh Awaiting requested review from stanleychh

@wdoberschuetz wdoberschuetz Awaiting requested review from wdoberschuetz

Assignees

@JohannesDoberer JohannesDoberer

Labels
enhancement New feature or request
Projects
None yet
Milestone
Sprint 21
Development

Successfully merging this pull request may close these issues.
2 participants
@UlianaMunich @JohannesDoberer