Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changeable routing config properties #2350

Conversation

JohannesDoberer
Copy link
Contributor

Only docu for defaults.sideNavAccordionMode was at the wrong place. It belongs to navigation and not to routing.
#2337

Copy link
Contributor

@alexandra-simeonova alexandra-simeonova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docu looks good 👍 There are some other changes showing in package-lock.json but I guess those are from merging the master branch into this branch? So LGTM.

@JohannesDoberer JohannesDoberer merged commit 5b852a4 into SAP:master Oct 26, 2021
@JohannesDoberer JohannesDoberer deleted the changeable-routing-config-properties- branch October 26, 2021 11:55
@JohannesDoberer JohannesDoberer mentioned this pull request Nov 2, 2021
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants