-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Searchfield configurable #2385
Merged
JohannesDoberer
merged 55 commits into
SAP:master
from
JohannesDoberer:searchfield-configurable
Dec 14, 2021
Merged
Searchfield configurable #2385
JohannesDoberer
merged 55 commits into
SAP:master
from
JohannesDoberer:searchfield-configurable
Dec 14, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/luigi into searchfield-configurable
JohannesDoberer
added
enhancement
New feature or request
and removed
WIP
Work in progress
labels
Nov 18, 2021
JohannesDoberer
requested review from
alexandra-simeonova,
hardl,
ndricimrr,
rafalgamon,
stanleychh,
UlianaMunich and
wdoberschuetz
as code owners
November 18, 2021 14:55
Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com>
…searchfield-configurable
# Conflicts: # core/package.json # test/e2e-test-application/e2e/tests/0-fiddle/fiddle-navigation.spec.js
stanleychh
reviewed
Dec 9, 2021
stanleychh
reviewed
Dec 10, 2021
stanleychh
reviewed
Dec 10, 2021
JohannesDoberer
requested review from
stanleychh and
UlianaMunich
and removed request for
UlianaMunich
December 13, 2021 20:56
stanleychh
approved these changes
Dec 14, 2021
Merged
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up:
#2415